Re: [PATCH] perf: support running perf binaries with a dash in their name

[Milian Wolff <milian.wolff@kdab.com>]

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

On Monday, September 11, 2017 4:33:12 PM CEST Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 11, 2017 at 07:08:18AM -0700, David Ahern escreveu:
> > On 9/11/17 4:14 AM, Milian Wolff wrote:
> > > Previously the part behind "perf-" was interpreted as an internal
> > > perf command. If the suffix could not be handled, the execution
> 
> <SNIP>
> 
> > > --- a/tools/perf/perf.c
> > > -		fprintf(stderr, "cannot handle %s internally", cmd);
> > > -		goto out;
> > > +		// if the command is handled, the above function does not return
> > > +		// undo changes and fall through in such a case
> > 
> > Those should be /* */ not //
> > 
> > > +		cmd -= 5;
> > > +		argv[0] = cmd;
> > > 
> > >  	}
> > >  	if (strstarts(cmd, "trace")) {
> > >  
> > >  #ifdef HAVE_LIBAUDIT_SUPPORT
> > 
> > other than that LGTM and long over due.
> > 
> > Acked-by: David Ahern <dsahern@gmail.com>
> 
> We got those from git, agreed it should go, thanks for the Acked-by,
> always welcome!

Arnaldo, do you want me to fixup the commit, or can you handle it?

Thanks for the review guys

-- 
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3826 bytes --]