From: Milian Wolff <milian.wolff@kdab.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, Linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames
Date: Sun, 01 Oct 2017 14:37:56 +0200 [thread overview]
Message-ID: <1648232.PM1aBqIB3I@agathebauer> (raw)
In-Reply-To: <20170919122711.GA13388@krava>
On Dienstag, 19. September 2017 14:27:11 CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:
>
> SNIP
>
> > -struct inline_node *dso__parse_addr_inlines(struct dso *dso, u64 addr);
> > +// parse inlined frames for the given address
> > +struct inline_node *dso__parse_addr_inlines(struct dso *dso, u64 addr,
> > + struct symbol *sym);
> > +// free resources associated to the inline node list
> >
> > void inline_node__delete(struct inline_node *node);
> >
> > +// insert the inline node list into the DSO, which will take ownership
> > +void inlines__tree_insert(struct rb_root *tree, struct inline_node
> > *inlines); +// find previously inserted inline node list
> > +struct inline_node *inlines__tree_find(struct rb_root *tree, u64 addr);
> > +// delete all nodes within the tree of inline_node s
> > +void inlines__tree_delete(struct rb_root *tree);
>
> nit, think we prefer the /* */ comment style
I'll fix this, but note that there are more places outside this patch series
where this style has crept in. Some of them also from past patches of mine -
sorry for that.
I looks to me as if the checkpatch.pl should catch this, but it doesn't for me
which is odd. Does anyone know what I need to do to enable the C99_COMMENTS
check?
~~~~~
┌milian@agathebauer:~/projects/src/linux/tools/perf|wip/distinguish-inliners<>
└$ grep '// ' 0009-perf-report-properly-handle-branch-count-in-match_ch.patch
- // if no srcline is available, fallback to symbol name
- // otherwise fall-back to IP-based comparison below
- // compare inlined frames based on their symbol name because
- // different inlined frames will have the same symbol start
+ // else fall-through
+ // compare inlined frames based on their symbol name
+ // because different inlined frames will have the same
+ // symbol start. otherwise do a faster comparison
based
+ // on the symbol start address
+ // else fall-through
┌milian@agathebauer:~/projects/src/linux/tools/perf|wip/distinguish-inliners<>
└$ ../../scripts/checkpatch.pl --strict 0009-perf-report-properly-handle-
branch-count-in-match_ch.patch
total: 0 errors, 0 warnings, 0 checks, 136 lines checked
0009-perf-report-properly-handle-branch-count-in-match_ch.patch has no obvious
style problems and is ready for submission.
~~~~~
Cheers
--
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
next prev parent reply other threads:[~2017-10-01 12:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 13:54 [PATCH v3 00/13] generate full callchain cursor entries for inlined frames Milian Wolff
2017-09-06 13:54 ` [PATCH v3 01/13] perf report: remove code to handle inline frames from browsers Milian Wolff
2017-09-18 11:56 ` Jiri Olsa
2017-09-18 12:43 ` Milian Wolff
2017-09-06 13:54 ` [PATCH v3 02/13] perf util: store srcline in callchain_cursor_node Milian Wolff
2017-09-06 13:54 ` [PATCH v3 03/13] perf report: create real callchain entries for inlined frames Milian Wolff
2017-09-19 12:27 ` Jiri Olsa
2017-10-01 12:37 ` Milian Wolff [this message]
2017-10-01 17:40 ` Joe Perches
2017-09-19 12:27 ` Jiri Olsa
2017-10-01 14:12 ` Milian Wolff
2017-09-19 12:27 ` Jiri Olsa
2017-10-01 12:40 ` Milian Wolff
2017-09-06 13:54 ` [PATCH v3 04/13] perf report: fall-back to function name comparison for -g srcline Milian Wolff
2017-09-06 13:54 ` [PATCH v3 05/13] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff
2017-09-06 13:54 ` [PATCH v3 06/13] perf script: mark inlined frames and do not print DSO for them Milian Wolff
2017-09-06 13:54 ` [PATCH v3 07/13] perf report: compare symbol name for inlined frames when matching Milian Wolff
2017-09-06 13:54 ` [PATCH v3 08/13] perf report: compare symbol name for inlined frames when sorting Milian Wolff
2017-09-06 13:54 ` [PATCH v3 09/13] perf report: properly handle branch count in match_chain Milian Wolff
2017-09-06 13:54 ` [PATCH v3 10/13] perf report: cache failed lookups of inlined frames Milian Wolff
2017-09-06 13:54 ` [PATCH v3 11/13] perf report: cache srclines for callchain nodes Milian Wolff
2017-09-06 13:55 ` [PATCH v3 12/13] perf report: use srcline from callchain for hist entries Milian Wolff
2017-09-06 13:55 ` [PATCH v3 13/13] perf util: enable handling of inlined frames by default Milian Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1648232.PM1aBqIB3I@agathebauer \
--to=milian.wolff@kdab.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).