From: Namhyung Kim <namhyung@kernel.org>
To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Sandipan Das <sandipan.das@amd.com>
Cc: eranian@google.com, jolsa@kernel.org, ananth.narayan@amd.com,
acme@kernel.org, peterz@infradead.org, irogers@google.com,
alexander.shishkin@linux.intel.com, adrian.hunter@intel.com,
ravi.bangoria@amd.com, mark.rutland@arm.com, mingo@redhat.com
Subject: Re: [PATCH] perf vendor events amd: Fix Zen 4 cache latency events
Date: Mon, 4 Mar 2024 10:56:44 -0800 [thread overview]
Message-ID: <170957856863.1606352.5043156720799964711.b4-ty@kernel.org> (raw)
In-Reply-To: <20240301084431.646221-1-sandipan.das@amd.com>
On Fri, 1 Mar 2024 14:14:31 +0530, Sandipan Das wrote:
> L3PMCx0AC and L3PMCx0AD, used in l3_xi_sampled_latency* events, have a
> quirk that requires them to be programmed with SliceId set to 0x3.
> Without this, the events do not count at all and affects dependent
> metrics such as l3_read_miss_latency.
>
> If ThreadMask is not specified, the amd-uncore driver internally sets
> ThreadMask to 0x3, EnAllCores to 0x1 and EnAllSlices to 0x1 but does
> not set SliceId. Since SliceId must also be set to 0x3 in this case,
> specify all the other fields explicitly.
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
--
Namhyung Kim <namhyung@kernel.org>
prev parent reply other threads:[~2024-03-04 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 8:44 [PATCH] perf vendor events amd: Fix Zen 4 cache latency events Sandipan Das
2024-03-01 16:39 ` Ian Rogers
2024-03-04 18:56 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170957856863.1606352.5043156720799964711.b4-ty@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox