From: Namhyung Kim <namhyung@kernel.org>
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, kan.liang@linux.intel.com,
adrian.hunter@intel.com, jserv@ccns.ncku.edu.tw,
chuang@cs.nycu.edu.tw, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] perf ftrace: Fix undefined behavior in cmp_profile_data()
Date: Wed, 11 Dec 2024 09:23:42 -0800 [thread overview]
Message-ID: <173393782213.3536107.18239500348967688224.b4-ty@kernel.org> (raw)
In-Reply-To: <20241209134226.1939163-1-visitorckw@gmail.com>
On Mon, 09 Dec 2024 21:42:26 +0800, Kuan-Wei Chiu wrote:
> The comparison function cmp_profile_data() violates the C standard's
> requirements for qsort() comparison functions, which mandate symmetry
> and transitivity:
>
> * Symmetry: If x < y, then y > x.
> * Transitivity: If x < y and y < z, then x < z.
>
> [...]
Applied to perf-tools, thanks!
Best regards,
Namhyung
prev parent reply other threads:[~2024-12-11 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 13:42 [PATCH] perf ftrace: Fix undefined behavior in cmp_profile_data() Kuan-Wei Chiu
2024-12-09 17:02 ` Namhyung Kim
2024-12-09 20:26 ` Arnaldo Carvalho de Melo
2024-12-09 21:48 ` Namhyung Kim
2024-12-11 17:23 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173393782213.3536107.18239500348967688224.b4-ty@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=chuang@cs.nycu.edu.tw \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox