From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
tlipcon@google.com, eranian@google.com
Subject: Re: [PATCH] perf symbol: Do not use debug file as the binary type
Date: Mon, 31 Aug 2026 21:14:48 -0700 [thread overview]
Message-ID: <178823608815.2655665.2768472262374178339.b4-ty@kernel.org> (raw)
In-Reply-To: <20260825062345.115073-1-adrian.hunter@intel.com>
On Tue, 25 Aug 2026 09:23:45 +0300, Adrian Hunter wrote:
> dso__load() sets the binary type of a DSO to the type of the first symbol
> source found. For a DSO with a separate debug file linked via
> .gnu-debuglink, that is DSO_BINARY_TYPE__DEBUGLINK, which makes
> dso__get_filename() return the name of the debug file instead of the file
> that was actually executed.
>
> Consumers that need to read instruction bytes, such as Intel PT decoding
> in 'perf script', then read from the debug file and produce wrong
> instructions.
>
> [...]
Applied to perf-tools, thanks!
Best regards,
Namhyung
prev parent reply other threads:[~2026-09-01 4:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 6:23 [PATCH] perf symbol: Do not use debug file as the binary type Adrian Hunter
2026-08-25 6:41 ` sashiko-bot
2026-08-25 18:13 ` Ian Rogers
2026-08-27 19:36 ` Namhyung Kim
2026-08-30 13:10 ` Arnaldo Carvalho de Melo
2026-09-01 4:14 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178823608815.2655665.2768472262374178339.b4-ty@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=tlipcon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox