Re: [PATCH 3/3] perf jevents: Check the JSON keys that jevents.py never reads

[TAKANO Mitsuhiro <takano32@gmail.com>]

Both findings are in my tree.

The missing Fixes: tag, which you raised against 2/3: adding nargs='?'
to the model argument is fixing a hole in 5a09b1fd1b1f ("perf jevents:
Add model list option"), so the tag belongs there.  It is in the commit
now, so the next revision of 2/3 carries it.

The sibling hint, which you raised against 3/3: you are right, and the
suppression has to go rather than be narrowed.  get_close_matches(n=2)
on a key such as RetirementLatencyMxi returns both RetirementLatencyMin
and RetirementLatencyMax, and the code kept quiet when the other
candidate was present and carried the same value in its table.  But the
value does not say which of the two names the author meant, and the JSON
object can hold only one of them, so a metric written next to a correct
sibling with the same value was the one case that disappeared: measured
on a table that has RetirementLatencyMin and a misspelled
RetirementLatencyMxi with the same value, the check exited 0 and
reported nothing before the change, and reports the key and exits 1
after it.

Reporting both names is noisier, which is the trade: the report names
the key that was not read, and the two candidates are the nearest names
to it.  A table with no typo produces no output either way.