Linux Perf Users
 help / color / mirror / Atom feed
From: TAKANO Mitsuhiro <takano32@gmail.com>
To: linux-perf-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>, TAKANO Mitsuhiro <takano32@gmail.com>
Subject: Re: [PATCH v3] perf stat: Start tool events when enable_on_exec is used
Date: Fri, 13 Nov 2026 07:07:05 +0000	[thread overview]
Message-ID: <179455362572.754258.3537940037051974310@gmail.com> (raw)
In-Reply-To: <20261023101256.1752713-1-takano32@gmail.com>

A ping on this one: three weeks since v3, and the only reply is the
automated review.

Nothing has changed on my side, and v3 is still the version I would
stand behind.  Both rounds of that review are addressed in it: the tool
event is started through evsel__tool_pmu_enable() rather than
evsel__enable(), so the members of a mixed group are left to the kernel,
and an event that failed to open is skipped instead of being started and
then read through a NULL core.fd.

The limitation stands: this machine does not allow perf_event_open for
the events involved, so the wrong output was read from the code - a
zeroed duration_time turning CPUs_utilized into a division by zero - and
not produced here.  A reviewer with the hardware can see it in one run.

If it is not wanted, say so and I will drop it.  If it wants a different
shape - a selftest, a smaller change, a different call site - tell me
which and I will send a v4.

Written with Hermes Agent, an LLM assistant; the author reviewed it.


      parent reply	other threads:[~2026-11-13  7:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  2:49 [PATCH] perf stat: Start tool events when enable_on_exec is used TAKANO Mitsuhiro
2026-10-22  3:14 ` sashiko-bot
2026-10-23  8:55 ` [PATCH v2] " TAKANO Mitsuhiro
2026-10-23  9:22   ` sashiko-bot
2026-10-23 10:12   ` [PATCH v3] " TAKANO Mitsuhiro
2026-10-23 10:23     ` sashiko-bot
2026-11-13  7:07     ` TAKANO Mitsuhiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179455362572.754258.3537940037051974310@gmail.com \
    --to=takano32@gmail.com \
    --cc=acme@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox