From: Milian Wolff <milian.wolff@kdab.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf trace: add total time column to summary.
Date: Thu, 06 Aug 2015 11:53:42 +0200 [thread overview]
Message-ID: <1825374.qTnqrC8ilh@milian-kdab2> (raw)
In-Reply-To: <1438853069-5902-1-git-send-email-milian.wolff@kdab.com>
Hey Arnaldo,
On Thursday 06 August 2015 11:24:29 Milian Wolff wrote:
<snip>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
I hope this patch is OK. I have some more questions:
a) Should I always send to linux-kernel and CC linux-perf-users, or is it OK
to send it only to linux-perf-users?
b) Should I put you explicitly into the CC, I recon you also read the mailing
lists?
c) Should I add more people to the CC list? The get_maintainer script also
lists Ingo Molnar and Peter Zijlstra, but your recent patch set has them not
in the CC list.
d) My patch has some warnings according to checkpatch, because some lines are
too long. Is this very frowned upon in the Kernel? It would make the table
much harder to read when I split it onto multiple lines, but of course I can
amend that if you want it.
If I messed up anything else, please tell me.
Thanks
--
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
next prev parent reply other threads:[~2015-08-06 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 9:24 [PATCH] perf trace: add total time column to summary Milian Wolff
2015-08-06 9:53 ` Milian Wolff [this message]
2015-08-06 13:17 ` Arnaldo Carvalho de Melo
2015-08-07 1:31 ` Wangnan (F)
2015-08-07 2:05 ` More details about submitting pull requests to upstream was: " Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1825374.qTnqrC8ilh@milian-kdab2 \
--to=milian.wolff@kdab.com \
--cc=acme@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).