Re: [Question] about symbol__get_source_line() in util/annotate.c

[Taeung Song <treeze.taeung@gmail.com>]

On 02/23/2017 02:26 PM, Namhyung Kim wrote:
> On Thu, Feb 23, 2017 at 02:14:13PM +0900, Namhyung Kim wrote:
>> Hi Taeung,
>>
>> On Thu, Feb 23, 2017 at 12:31:08PM +0900, Taeung Song wrote:
>>> 2) Why use the if statement as below ?
>>>
>>>     if (percent_max <= 0.5)
>>>             goto next;
>>>
>>> I think it is more correct to use 0.0 instead of 0.5
>>>
>>> What do you think about that ?
>>
>> Well, I think that the summary line doesn't want to show too many
>> (small) lines.  Using 0.0 instead seems meaningless though.
>
> Ah, that includes 0 percent..
>
> Anyway I can see print_summary() uses MIN_GREEN for this.  We can use
> it here instead of the magic number, or might change it to something
> different if needed.
>
> Thanks,
> Namhyung
>

I understood!
Thanks for your answer

P.S.
Hum.. And I think there are many things that seem to need to be
modified in util/annotate.c
The for loop util/annotate.c:1653~1676
have similar logic if compared with disasm__calc_percent

Anyway I'll keep trying to improve perf-annotate in terms of its 
features and its code..

Thanks,
Taeung