From: David Hildenbrand <david@redhat.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-perf-users@vger.kernel.org,
selinux@vger.kernel.org
Subject: Re: [PATCH 2/5] mm: use vma_is_stack() and vma_is_heap()
Date: Mon, 17 Jul 2023 12:25:43 +0200 [thread overview]
Message-ID: <2000511c-d551-5b3d-a9a9-adb4ba3be1f1@redhat.com> (raw)
In-Reply-To: <20230712143831.120701-3-wangkefeng.wang@huawei.com>
On 12.07.23 16:38, Kefeng Wang wrote:
> Use the helpers to simplify code.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> fs/proc/task_mmu.c | 24 ++++--------------------
> fs/proc/task_nommu.c | 15 +--------------
> 2 files changed, 5 insertions(+), 34 deletions(-)
>
Please squash patch #1 and this patch and call it something like
"mm: factor out VMA stack and heap checks"
And then, maybe also keep the comments in these functions, they sound
reasonable to have.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-07-17 10:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 14:38 [PATCH 0/5] mm: convert to vma_is_heap/stack() Kefeng Wang
2023-07-12 14:38 ` [PATCH 1/5] mm: introduce vma_is_stack() and vma_is_heap() Kefeng Wang
2023-07-17 10:26 ` David Hildenbrand
2023-07-18 15:10 ` Christian Göttsche
2023-07-12 14:38 ` [PATCH 2/5] mm: use " Kefeng Wang
2023-07-17 10:25 ` David Hildenbrand [this message]
2023-07-18 0:50 ` Kefeng Wang
2023-07-12 14:38 ` [PATCH 3/5] drm/amdkfd: " Kefeng Wang
2023-07-12 14:42 ` Christoph Hellwig
2023-07-12 16:24 ` Felix Kuehling
2023-07-14 14:26 ` Vlastimil Babka
2023-07-14 15:09 ` Felix Kuehling
2023-07-12 14:38 ` [PATCH 4/5] selinux: " Kefeng Wang
2023-07-17 16:12 ` Paul Moore
2023-07-12 14:38 ` [PATCH 5/5] perf/core: " Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2000511c-d551-5b3d-a9a9-adb4ba3be1f1@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=selinux@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).