From: Thomas Renninger <trenn@suse.de>
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org,
Arjan van de Ven <arjan@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 7/8] perf timechart: Map power:cpu_idle events to the corresponding cpuidle state
Date: Thu, 2 Dec 2010 17:51:39 +0100 [thread overview]
Message-ID: <201012021751.39865.trenn@suse.de> (raw)
In-Reply-To: <1291308148-28628-8-git-send-email-trenn@suse.de>
On Thursday 02 December 2010 17:42:27 Thomas Renninger wrote:
> Before, power:cpu_idle events were very specific X86 Intel mwait events.
> This got fixed with previous patches and cpu_idle events are now thrown by
> all cpuidle drivers and can be mapped to the corresponding cpuidle state
> in /sys.
>
> This patch reads out the corresponding cpuidle name of a cpu_idle event
> and uses it in the title line of the chart (c-states Cx in x86, omap2
> - DDR self refresh states for various arm archs).
>
> It also reads out the corresponding abbr(eviation) and uses the string
> to draw the cpu idle occurences. This needs a short (3 letter) string
> to keep the overview in the chart.
I forgot two other changes:
- Fixes black c-state drawings in eog and firefox:
class="rect.cX" is wrong and must be class="cX"
- Use green color instead of red for idle drawings. This does not clash
with the Block IO drawings (also red) and better fits the "green IT"
background the C-states are about :) (that was not really the reason,
green was one of the last not used colors)...
Thomas
prev parent reply other threads:[~2010-12-02 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1291308148-28628-1-git-send-email-trenn@suse.de>
[not found] ` <1291308148-28628-2-git-send-email-trenn@suse.de>
[not found] ` <1291308148-28628-3-git-send-email-trenn@suse.de>
2010-12-02 16:42 ` [PATCH 3/8] X86/perf: fix power:cpu_idle double end events and throw cpu_idle events from the cpuidle layer Thomas Renninger
[not found] ` <1291308148-28628-5-git-send-email-trenn@suse.de>
[not found] ` <1291308148-28628-6-git-send-email-trenn@suse.de>
[not found] ` <1291308148-28628-7-git-send-email-trenn@suse.de>
2010-12-02 16:42 ` [PATCH 7/8] perf timechart: Map power:cpu_idle events to the corresponding cpuidle state Thomas Renninger
2010-12-02 16:42 ` [PATCH 8/8] perf: timechart: Fix memleak Thomas Renninger
2010-12-02 16:51 ` Thomas Renninger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012021751.39865.trenn@suse.de \
--to=trenn@suse.de \
--cc=arjan@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).