From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"David S. Ahern" <daahern@cisco.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf tools: Add reference timestamp to perf header
Date: Mon, 13 Dec 2010 18:15:40 +0100 [thread overview]
Message-ID: <20101213171537.GC1691@nowhere> (raw)
In-Reply-To: <1292260289.6803.297.camel@twins>
On Mon, Dec 13, 2010 at 06:11:29PM +0100, Peter Zijlstra wrote:
> On Mon, 2010-12-13 at 18:09 +0100, Frederic Weisbecker wrote:
> >
> >
> > Right, but Peter wanted us to get rid of these user events types.
>
> Yes they suck.
>
> > I guess we can't really do this as new perf tools must be able
> > to support old perf files.
>
> Preferably, yes, but I don't see why we can't break the data file format
> if we've got good reasons to.
IMO we should prioritize the backward compatibility over some little code sanity.
It's worth a very small range of values to reserve in the kernel and we are done.
> > So this should be the last one to add. Something like PERF_RECORD_GEN_EVT
> > that has a field in its headers containing a sub-type which can be this
> > wall clock but can also host about everything in the future.
> >
> > This way we don't propagate more the possible overlap with the kernel.
>
> I don't see why we should add more, that's going the wrong direction.
This must be the last one.
next prev parent reply other threads:[~2010-12-13 17:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 1:54 [PATCH 0/2] perf tools: add reference timestamp and use it in time history dump David Ahern
2010-12-08 1:54 ` [PATCH 1/2] perf tools: Add reference timestamp to perf header David Ahern
2010-12-12 20:16 ` Frederic Weisbecker
2010-12-13 13:15 ` Arnaldo Carvalho de Melo
2010-12-13 16:58 ` Arnaldo Carvalho de Melo
2010-12-13 14:39 ` David S. Ahern
2010-12-13 15:54 ` Frederic Weisbecker
2010-12-13 16:48 ` Arnaldo Carvalho de Melo
2010-12-13 17:09 ` Frederic Weisbecker
2010-12-13 17:11 ` Peter Zijlstra
2010-12-13 17:13 ` Peter Zijlstra
2010-12-13 17:23 ` Frederic Weisbecker
2010-12-13 17:37 ` Peter Zijlstra
2010-12-13 17:50 ` Frederic Weisbecker
2010-12-13 17:15 ` Frederic Weisbecker [this message]
2010-12-13 17:18 ` Peter Zijlstra
2010-12-13 17:22 ` Arnaldo Carvalho de Melo
2010-12-13 17:35 ` Peter Zijlstra
2010-12-13 17:43 ` Arnaldo Carvalho de Melo
2010-12-13 17:51 ` Peter Zijlstra
2010-12-13 18:05 ` Frederic Weisbecker
2010-12-13 18:10 ` Peter Zijlstra
2010-12-13 17:47 ` Peter Zijlstra
2010-12-13 17:49 ` David S. Ahern
2010-12-13 17:57 ` Peter Zijlstra
2010-12-13 18:01 ` David S. Ahern
2010-12-13 18:06 ` Peter Zijlstra
2010-12-13 18:20 ` David S. Ahern
2010-12-13 19:08 ` Arnaldo Carvalho de Melo
2010-12-13 19:15 ` David S. Ahern
2010-12-13 19:22 ` Peter Zijlstra
2010-12-13 19:17 ` Peter Zijlstra
2010-12-13 17:48 ` Peter Zijlstra
2010-12-13 17:14 ` Arnaldo Carvalho de Melo
2010-12-13 17:36 ` David S. Ahern
2010-12-13 17:51 ` Arnaldo Carvalho de Melo
2010-12-08 1:54 ` [PATCH 2/2] perf tools: Add option to show time history of event samples David Ahern
2010-12-08 21:06 ` Arnaldo Carvalho de Melo
2010-12-12 21:32 ` Frederic Weisbecker
2010-12-09 17:18 ` [PATCH 0/2] perf tools: add reference timestamp and use it in time history dump Arnaldo Carvalho de Melo
2010-12-12 21:39 ` Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2010-11-29 23:07 [PATCH 0/2] perf tools: reference timestamp and " David Ahern
2010-11-29 23:07 ` [PATCH 1/2] perf tools: add reference timestamp to perf header David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213171537.GC1691@nowhere \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=daahern@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).