From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH 1/2] perf tools: Add reference timestamp to perf header Date: Mon, 13 Dec 2010 15:22:16 -0200 Message-ID: <20101213172216.GB7417@ghostprotocols.net> References: <1291773285-16254-1-git-send-email-daahern@cisco.com> <1291773285-16254-2-git-send-email-daahern@cisco.com> <20101212201613.GA1784@nowhere> <4D06301C.2090309@cisco.com> <20101213155451.GA1691@nowhere> <20101213164854.GL5407@ghostprotocols.net> <20101213170923.GB1691@nowhere> <1292260289.6803.297.camel@twins> <20101213171537.GC1691@nowhere> <1292260699.6803.305.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:42947 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752607Ab0LMRWX (ORCPT ); Mon, 13 Dec 2010 12:22:23 -0500 Content-Disposition: inline In-Reply-To: <1292260699.6803.305.camel@twins> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Frederic Weisbecker , "David S. Ahern" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Em Mon, Dec 13, 2010 at 06:18:19PM +0100, Peter Zijlstra escreveu: > On Mon, 2010-12-13 at 18:15 +0100, Frederic Weisbecker wrote: > > On Mon, Dec 13, 2010 at 06:11:29PM +0100, Peter Zijlstra wrote: > > > On Mon, 2010-12-13 at 18:09 +0100, Frederic Weisbecker wrote: > > > > So this should be the last one to add. Something like PERF_RECORD_GEN_EVT > > > > that has a field in its headers containing a sub-type which can be this > > > > wall clock but can also host about everything in the future. > > > > > > > > This way we don't propagate more the possible overlap with the kernel. > > > > > > I don't see why we should add more, that's going the wrong direction. > > > > This must be the last one. > > No, the last one already happened, you cannot postpone the last one, > there will always be another excuse. Did you understand the use case? How to have multiple reference times when appending? "last one" means adding a multiplexor, PERF_RECORD_LAST_ONE if you will, and inside it we add new events if the need arises. Then never again we add a PERF_RECORD_ event in userspace. - Arnaldo