From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: "David S. Ahern" <daahern@cisco.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf tools: Add reference timestamp to perf header
Date: Mon, 13 Dec 2010 17:08:31 -0200 [thread overview]
Message-ID: <20101213190831.GA7984@ghostprotocols.net> (raw)
In-Reply-To: <4D065F69.7080707@cisco.com>
Em Mon, Dec 13, 2010 at 11:01:13AM -0700, David S. Ahern escreveu:
> On 12/13/10 10:57, Peter Zijlstra wrote:
> >> What about creating a PERF_RECORD_TIME and generate an event when the
> >> counter is opened? It contains a PERF_SAMPLE_TIME and say
> >> PERF_SAMPLE_TOD (time-of-day)? We're not sending rockets to saturn; we
> >> just need the timestamps to match other log files.
> > That's similar to the first thing I proposed. The problem is with long
> > record sessions your drift can become quite significant, then when you
> > merge sort your other log events stuff can get out of order. Which can
> > lead to some serious head-scratching..
> Gotcha. Missed that in the flury of emails.
> Arnaldo: Are you ok with this option? This should append mode as well.
What option, this one:
-----------------------------------------------------------------------
Peter Zijlstra wrote:
> In fact, the only sane way to do that is by creating a software counter
> that represents CLOCK_MONOTONIC and sample that say once a minute (or
> more often if you want smaller drift).
-----------------------------------------------------------------------
?
Yes, that looks the best option. I.e. no changes on headers, no new
user fake events, a new software event that may be useful for other
usecases.
We have:
[acme@mica linux]$ perf list | grep -- -clock
cpu-clock [Software event]
task-clock [Software event]
[acme@mica linux]$
So we would have a new one:
monotonic-clock
Peter, agreed? I'll try to implement it now, good opportunity to learn a
bit more about soft pmus, I'd have to do that anyway for NIC stats, etc.
- Arnaldo
next prev parent reply other threads:[~2010-12-13 19:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 1:54 [PATCH 0/2] perf tools: add reference timestamp and use it in time history dump David Ahern
2010-12-08 1:54 ` [PATCH 1/2] perf tools: Add reference timestamp to perf header David Ahern
2010-12-12 20:16 ` Frederic Weisbecker
2010-12-13 13:15 ` Arnaldo Carvalho de Melo
2010-12-13 16:58 ` Arnaldo Carvalho de Melo
2010-12-13 14:39 ` David S. Ahern
2010-12-13 15:54 ` Frederic Weisbecker
2010-12-13 16:48 ` Arnaldo Carvalho de Melo
2010-12-13 17:09 ` Frederic Weisbecker
2010-12-13 17:11 ` Peter Zijlstra
2010-12-13 17:13 ` Peter Zijlstra
2010-12-13 17:23 ` Frederic Weisbecker
2010-12-13 17:37 ` Peter Zijlstra
2010-12-13 17:50 ` Frederic Weisbecker
2010-12-13 17:15 ` Frederic Weisbecker
2010-12-13 17:18 ` Peter Zijlstra
2010-12-13 17:22 ` Arnaldo Carvalho de Melo
2010-12-13 17:35 ` Peter Zijlstra
2010-12-13 17:43 ` Arnaldo Carvalho de Melo
2010-12-13 17:51 ` Peter Zijlstra
2010-12-13 18:05 ` Frederic Weisbecker
2010-12-13 18:10 ` Peter Zijlstra
2010-12-13 17:47 ` Peter Zijlstra
2010-12-13 17:49 ` David S. Ahern
2010-12-13 17:57 ` Peter Zijlstra
2010-12-13 18:01 ` David S. Ahern
2010-12-13 18:06 ` Peter Zijlstra
2010-12-13 18:20 ` David S. Ahern
2010-12-13 19:08 ` Arnaldo Carvalho de Melo [this message]
2010-12-13 19:15 ` David S. Ahern
2010-12-13 19:22 ` Peter Zijlstra
2010-12-13 19:17 ` Peter Zijlstra
2010-12-13 17:48 ` Peter Zijlstra
2010-12-13 17:14 ` Arnaldo Carvalho de Melo
2010-12-13 17:36 ` David S. Ahern
2010-12-13 17:51 ` Arnaldo Carvalho de Melo
2010-12-08 1:54 ` [PATCH 2/2] perf tools: Add option to show time history of event samples David Ahern
2010-12-08 21:06 ` Arnaldo Carvalho de Melo
2010-12-12 21:32 ` Frederic Weisbecker
2010-12-09 17:18 ` [PATCH 0/2] perf tools: add reference timestamp and use it in time history dump Arnaldo Carvalho de Melo
2010-12-12 21:39 ` Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2010-11-29 23:07 [PATCH 0/2] perf tools: reference timestamp and " David Ahern
2010-11-29 23:07 ` [PATCH 1/2] perf tools: add reference timestamp to perf header David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213190831.GA7984@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=daahern@cisco.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).