linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Thomas Renninger <trenn@suse.de>,
	mingo@elte.hu, Arjan van de Ven <arjan@infradead.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: Fix timechart idle box drawings
Date: Sat, 22 Jan 2011 22:37:43 -0200	[thread overview]
Message-ID: <20110123003743.GB17936@ghostprotocols.net> (raw)
In-Reply-To: <1295620209-13859-1-git-send-email-trenn@suse.de>

Em Fri, Jan 21, 2011 at 03:30:08PM +0100, Thomas Renninger escreveu:
> Without this patch eye of gnome and firfox will draw the
> boxes black.
> Compare with the other box declartions, looks
> like some typos slipped in which get fixed with this
> patch.
> 
> Signed-off-by: Thomas Renninger <trenn@suse.de>
> CC: arjan@infradead.org
> CC: mingo@elte.hu
> CC: linux-perf-users@vger.kernel.org

Arjan,

	Are you OK with this? Can I have your acked-by for it?

- Arnaldo


>  tools/perf/util/svghelper.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c
> index b3637db..8ee5d11 100644
> --- a/tools/perf/util/svghelper.c
> +++ b/tools/perf/util/svghelper.c
> @@ -455,9 +455,9 @@ void svg_legenda(void)
>  		return;
>  
>  	svg_legenda_box(0,	"Running", "sample");
> -	svg_legenda_box(100,	"Idle","rect.c1");
> -	svg_legenda_box(200,	"Deeper Idle", "rect.c3");
> -	svg_legenda_box(350,	"Deepest Idle", "rect.c6");
> +	svg_legenda_box(100,	"Idle","c1");
> +	svg_legenda_box(200,	"Deeper Idle", "c3");
> +	svg_legenda_box(350,	"Deepest Idle", "c6");
>  	svg_legenda_box(550,	"Sleeping", "process2");
>  	svg_legenda_box(650,	"Waiting for cpu", "waiting");
>  	svg_legenda_box(800,	"Blocked on IO", "blocked");
> -- 
> 1.7.3.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2011-01-23  0:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 14:30 [PATCH] perf: Fix timechart idle box drawings Thomas Renninger
2011-01-21 14:30 ` [PATCH] perf: Fix time function double declaration with glibc Thomas Renninger
2011-01-23  0:37 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110123003743.GB17936@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=arjan@infradead.org \
    --cc=arjan@linux.intel.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).