[PATCH] perf: Fix timechart idle box drawings

[PATCH] perf: Fix timechart idle box drawings

[Thomas Renninger]

Without this patch eye of gnome and firfox will draw the
boxes black.
Compare with the other box declartions, looks
like some typos slipped in which get fixed with this
patch.

Signed-off-by: Thomas Renninger <trenn@suse.de>
CC: arjan@infradead.org
CC: mingo@elte.hu
CC: linux-perf-users@vger.kernel.org
---
 tools/perf/util/svghelper.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c
index b3637db..8ee5d11 100644
--- a/tools/perf/util/svghelper.c
+++ b/tools/perf/util/svghelper.c
@@ -455,9 +455,9 @@ void svg_legenda(void)
 		return;
 
 	svg_legenda_box(0,	"Running", "sample");
-	svg_legenda_box(100,	"Idle","rect.c1");
-	svg_legenda_box(200,	"Deeper Idle", "rect.c3");
-	svg_legenda_box(350,	"Deepest Idle", "rect.c6");
+	svg_legenda_box(100,	"Idle","c1");
+	svg_legenda_box(200,	"Deeper Idle", "c3");
+	svg_legenda_box(350,	"Deepest Idle", "c6");
 	svg_legenda_box(550,	"Sleeping", "process2");
 	svg_legenda_box(650,	"Waiting for cpu", "waiting");
 	svg_legenda_box(800,	"Blocked on IO", "blocked");
-- 
1.7.3.4

[PATCH] perf: Fix time function double declaration with glibc

[Thomas Renninger]

It's enough to include the local "debug.h" file to
trigger it.
man time reveals this is already declared in glibc:
time - get time in seconds
#include <time.h>
-> rename the variable.

Signed-off-by: Thomas Renninger <trenn@suse.de>
CC: arjan@infradead.org
CC: mingo@elte.hu
CC: linux-perf-users@vger.kernel.org
---
 tools/perf/util/svghelper.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c
index 8ee5d11..e40a00d 100644
--- a/tools/perf/util/svghelper.c
+++ b/tools/perf/util/svghelper.c
@@ -43,11 +43,11 @@ static double cpu2y(int cpu)
 	return cpu2slot(cpu) * SLOT_MULT;
 }
 
-static double time2pixels(u64 time)
+static double time2pixels(u64 __time)
 {
 	double X;
 
-	X = 1.0 * svg_page_width * (time - first_time) / (last_time - first_time);
+	X = 1.0 * svg_page_width * (__time - first_time) / (last_time - first_time);
 	return X;
 }
 
-- 
1.7.3.4

Re: [PATCH] perf: Fix timechart idle box drawings

[Arnaldo Carvalho de Melo]

Em Fri, Jan 21, 2011 at 03:30:08PM +0100, Thomas Renninger escreveu:
> Without this patch eye of gnome and firfox will draw the
> boxes black.
> Compare with the other box declartions, looks
> like some typos slipped in which get fixed with this
> patch.
> 
> Signed-off-by: Thomas Renninger <trenn@suse.de>
> CC: arjan@infradead.org
> CC: mingo@elte.hu
> CC: linux-perf-users@vger.kernel.org

Arjan,

	Are you OK with this? Can I have your acked-by for it?

- Arnaldo


>  tools/perf/util/svghelper.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c
> index b3637db..8ee5d11 100644
> --- a/tools/perf/util/svghelper.c
> +++ b/tools/perf/util/svghelper.c
> @@ -455,9 +455,9 @@ void svg_legenda(void)
>  		return;
>  
>  	svg_legenda_box(0,	"Running", "sample");
> -	svg_legenda_box(100,	"Idle","rect.c1");
> -	svg_legenda_box(200,	"Deeper Idle", "rect.c3");
> -	svg_legenda_box(350,	"Deepest Idle", "rect.c6");
> +	svg_legenda_box(100,	"Idle","c1");
> +	svg_legenda_box(200,	"Deeper Idle", "c3");
> +	svg_legenda_box(350,	"Deepest Idle", "c6");
>  	svg_legenda_box(550,	"Sleeping", "process2");
>  	svg_legenda_box(650,	"Waiting for cpu", "waiting");
>  	svg_legenda_box(800,	"Blocked on IO", "blocked");
> -- 
> 1.7.3.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html