From: Frederic Weisbecker <fweisbec@gmail.com>
To: David Ahern <daahern@cisco.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
acme@ghostprotocols.net, mingo@elte.hu, peterz@infradead.org,
paulus@samba.org, tglx@linutronix.de
Subject: Re: [PATCH 0/4] perf events: Add realtime clock event and timehist option -v2
Date: Mon, 21 Feb 2011 23:21:06 +0100 [thread overview]
Message-ID: <20110221222104.GE3583@nowhere> (raw)
In-Reply-To: <4D62E2B0.1070607@cisco.com>
On Mon, Feb 21, 2011 at 03:09:52PM -0700, David Ahern wrote:
>
>
> On 02/21/11 14:55, Frederic Weisbecker wrote:
> > On Mon, Feb 21, 2011 at 02:41:53PM -0700, David Ahern wrote:
> >>
> >>
> >> On 02/21/11 14:37, Frederic Weisbecker wrote:
> >>
> >>> The goal is actually to extend perf script to handle more than just raw data.
> >>> So that it can handle the rest of what we can find in an event: time, ip, stacktraces...
> >>>
> >>> You've added 200 lines in perf report to add the dump support. It wouldn't
> >>> require more to extend perf script to do that. And the result is going to be
> >>> much more powerful.
> >>>
> >>> Look at struct scripting_ops::process_event().
> >>
> >> I actually have a draft of perf-script - essentially duplicating sample
> >> processing done in perf-report. When it got to the point of having to
> >> add a lot of code -- other features essentially -- just to get it to the
> >> point of being ready for this feature I stopped.
> >
> >
> > I don't understand why it's harder to extend print_event() rather than
> > perf report.
>
> All of the changes to perf-report are related strictly to this feature -
> generating the timestamp and printing the sample including walking the
> callchain.
This is the actual drawback: it's only useful for your feature. My wish
is to have something more broadly useful. And support for callchains or
other things like this in perf script is desired and has been requested
by the past.
> perf-script needs to have features added to it:
> 1. working with all samples,
Why do you need that? You seem to be only interested in tracepoint
events.
Sure I would appreciate that perf script can support any event as a bonus
but that doesn't seem mandatory here.
> 2. support for callchains,
What does it take more than what you did in perf report, namely
calling perf_session_resolve_callchain and walking the cursor?
> 3. more?
?
next prev parent reply other threads:[~2011-02-21 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 21:02 [PATCH 0/4] perf events: Add realtime clock event and timehist option -v2 David Ahern
2011-02-21 21:02 ` [PATCH 1/4] perf events: Introduce realtime clock event David Ahern
2011-02-21 21:02 ` [PATCH 2/4] perf events: plumbing for PERF_SAMPLE_READ and read_format David Ahern
2011-02-21 21:02 ` [PATCH 3/4] perf events: add timehist option to record and report David Ahern
2011-02-21 21:02 ` [PATCH 4/4] perf stat: treat realtime-clock as nsec counter David Ahern
2011-02-21 21:37 ` [PATCH 0/4] perf events: Add realtime clock event and timehist option -v2 Frederic Weisbecker
2011-02-21 21:41 ` David Ahern
2011-02-21 21:55 ` Frederic Weisbecker
2011-02-21 22:09 ` David Ahern
2011-02-21 22:21 ` Frederic Weisbecker [this message]
2011-02-22 1:16 ` David Ahern
2011-02-22 2:50 ` Frederic Weisbecker
2011-02-22 7:41 ` Ingo Molnar
2011-02-22 8:07 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221222104.GE3583@nowhere \
--to=fweisbec@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=daahern@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).