From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Weisbecker Subject: Re: [PATCH 3/6] perf script: move printing of 'common' data from print_event and rename Date: Fri, 11 Mar 2011 01:28:15 +0100 Message-ID: <20110311002812.GA2023@nowhere> References: <1299734608-5223-1-git-send-email-daahern@cisco.com> <1299734608-5223-4-git-send-email-daahern@cisco.com> <20110310152053.GB12521@home.goodmis.org> <20110310155109.GB23555@ghostprotocols.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:56560 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044Ab1CKA2X (ORCPT ); Thu, 10 Mar 2011 19:28:23 -0500 Content-Disposition: inline In-Reply-To: <20110310155109.GB23555@ghostprotocols.net> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Arnaldo Carvalho de Melo Cc: Steven Rostedt , David Ahern , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu, peterz@infradead.org, paulus@samba.org, tglx@linutronix.de On Thu, Mar 10, 2011 at 12:51:09PM -0300, Arnaldo Carvalho de Melo wrot= e: > Em Thu, Mar 10, 2011 at 10:20:53AM -0500, Steven Rostedt escreveu: > > On Wed, Mar 09, 2011 at 10:23:25PM -0700, David Ahern wrote: > > > This change does impact output: latency data is trace specific an= d is now > > > printed after the common data - comm, tid, cpu, time and event na= me. >=20 > > > Signed-off-by: David Ahern >=20 > > > tools/perf/builtin-script.c | 38 +++++++++++++++++++++= +----- > > > tools/perf/util/trace-event-parse.c | 49 +++++++--------------= ------------- >=20 > > I was hoping after the next merge window to start making a common l= ibrary > > for parsing events. This way things like powertop and timechart or > > anything that uses the perf interface does not need to write its ow= n > > parsing of events, or expect the event formats to be hardcoded. > >=20 > > The trace-event-parse.c was taking from trace-cmd's parse-events.c = code > > and hopefully the two can merge again. The parse-events.c code in > > trace-cmd has gone through several iterations that has made it much= more > > robust and flexible. I purposely kept it as a separate libarary not > > dependent on trace-cmd so that it could be used by other utilities = like > > perf. >=20 > David is kinda new to this perf/ftrace/trace-cmd/etc soap opera, and = he > has been patient to go thru the motions with Peter, Thomas, Fr=E9d=E9= ric and > me, going from doing what he wants in 'perf report' to 'perf script', > etc. >=20 > We're almost to the point where his feature is implemented in a > way Fr=E9d=E9ric, the one most actively reviewing his work, is satisf= ied, > right Fr=E9d=E9ric? Yeah, nice work! Thanks David! Acked-by: Frederic Weisbecker