From: Ingo Molnar <mingo@elte.hu>
To: David Ahern <dsahern@gmail.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
acme@ghostprotocols.net, peterz@infradead.org,
fweisbec@gmail.com, paulus@samba.org, tglx@linutronix.de
Subject: Re: [PATCH v2] perf stat: clarify unsupported events from uncounted events
Date: Mon, 30 May 2011 10:24:34 +0200 [thread overview]
Message-ID: <20110530082434.GB30513@elte.hu> (raw)
In-Reply-To: <1306519614-19463-1-git-send-email-dsahern@gmail.com>
* David Ahern <dsahern@gmail.com> wrote:
> +++ b/tools/perf/util/evsel.h
> @@ -61,6 +61,7 @@ struct perf_evsel {
> off_t id_offset;
> };
> struct cgroup_sel *cgrp;
> + bool supported;
Nit: when adding new fields to structures please try to keep the
vertical alignment of existing fields.
Thanks,
Ingo
prev parent reply other threads:[~2011-05-30 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 18:06 [PATCH v2] perf stat: clarify unsupported events from uncounted events David Ahern
2011-05-30 8:24 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530082434.GB30513@elte.hu \
--to=mingo@elte.hu \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).