From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v2] perf stat: clarify unsupported events from uncounted events Date: Mon, 30 May 2011 10:24:34 +0200 Message-ID: <20110530082434.GB30513@elte.hu> References: <1306519614-19463-1-git-send-email-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:57076 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755844Ab1E3IYl (ORCPT ); Mon, 30 May 2011 04:24:41 -0400 Content-Disposition: inline In-Reply-To: <1306519614-19463-1-git-send-email-dsahern@gmail.com> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: David Ahern Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, acme@ghostprotocols.net, peterz@infradead.org, fweisbec@gmail.com, paulus@samba.org, tglx@linutronix.de * David Ahern wrote: > +++ b/tools/perf/util/evsel.h > @@ -61,6 +61,7 @@ struct perf_evsel { > off_t id_offset; > }; > struct cgroup_sel *cgrp; > + bool supported; Nit: when adding new fields to structures please try to keep the vertical alignment of existing fields. Thanks, Ingo