linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sam Liao <phyomh@gmail.com>, Arun Sharma <asharma@fb.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] [perf] Add inverted call graph report support.
Date: Thu, 16 Jun 2011 00:24:05 +0200	[thread overview]
Message-ID: <20110615222402.GB18579@somewhere.redhat.com> (raw)
In-Reply-To: <20110615081518.GC12496@elte.hu>

On Wed, Jun 15, 2011 at 10:15:18AM +0200, Ingo Molnar wrote:
> 
> * Sam Liao <phyomh@gmail.com> wrote:
> 
> > On Wed, Jun 15, 2011 at 6:15 AM, Arun Sharma <asharma@fb.com> wrote:
> > > Sam,
> > >
> > > $ perf report -g graph,0.5,caller --sort pid
> > >
> > > is a bit hard to type. Perhaps add a simpler command line option
> > > that has the same effect?
> > >
> > >  -Arun
> > >
> > >
> > 
> > How about perf report -g [caller/callee,][graph,0.1] -s pid
> > 
> > or remove the order of the options for "-g"
> 
> We could alias the -G flag to the inverse graph.

Agreed.
-g could map to fine tuning of callchain parameters like it does right now
and we can use -G as a shortcut for inverted callchain keeping the default
settings.
 
> Plus it would be nice to allow a .perfconfig flag for people to 
> configure their desired default reporting parameters.

Yeah.

It would be also nice to have a "caller" sorting mode:

	perf report -G -s caller

This can be useful to get the entire tree of calls for each callers.

  reply	other threads:[~2011-06-15 22:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09  6:44 [PATCH] [perf] Add inverted call graph report support Sam Liao
2011-06-09 19:33 ` Arun Sharma
2011-06-09 20:10   ` David Ahern
2011-06-09 20:13     ` Arun Sharma
2011-06-14 22:15   ` Arun Sharma
2011-06-15  6:01     ` Sam Liao
2011-06-15  8:15       ` Ingo Molnar
2011-06-15 22:24         ` Frederic Weisbecker [this message]
2011-06-10 20:42 ` Arnaldo Carvalho de Melo
2011-06-15 19:40   ` Frederic Weisbecker
2011-06-15 22:15 ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110615222402.GB18579@somewhere.redhat.com \
    --to=fweisbec@gmail.com \
    --cc=asharma@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=phyomh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).