linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: David Ahern <dsahern@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Ingo Molnar <mingo@elte.hu>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	paulus@samba.org, tglx@linutronix.de
Subject: Re: [PATCH] perf script: fix display of IP address for non-callchain path
Date: Sun, 17 Jul 2011 19:31:06 +0200	[thread overview]
Message-ID: <20110717173103.GB29355@somewhere> (raw)
In-Reply-To: <1306768587-15376-1-git-send-email-dsahern@gmail.com>

On Mon, May 30, 2011 at 09:16:27AM -0600, David Ahern wrote:
> Non-callchain path is using al.addr which prints as:
>   openssl 14564 17672.003587:       7862d _x86_64_AES_encrypt_compact
> 
> This should be sample->ip to print as:
>   openssl 14564 17672.003587:  3f7867862d _x86_64_AES_encrypt_compact
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>

> ---
>  tools/perf/util/session.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index e6cf0e2..360d8c4 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1247,7 +1247,7 @@ void perf_session__print_ip(union perf_event *event,
>  		}
>  
>  	} else {
> -		printf("%16" PRIx64, al.addr);
> +		printf("%16" PRIx64, sample->ip);
>  		if (print_sym) {
>  			if (al.sym && al.sym->name)
>  				symname = al.sym->name;
> -- 
> 1.7.5.2
> 

      reply	other threads:[~2011-07-17 17:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30 15:16 [PATCH] perf script: fix display of IP address for non-callchain path David Ahern
2011-07-17 17:31 ` Frederic Weisbecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110717173103.GB29355@somewhere \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).