From mboxrd@z Thu Jan  1 00:00:00 1970
From: Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH v2] perf tools: fix endian conversion reading event attr
 from file header
Date: Sun, 17 Jul 2011 20:12:04 +0200
Message-ID: <20110717181202.GC29355@somewhere>
References: <1310754849-12474-1-git-send-email-dsahern@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-perf-users-owner@vger.kernel.org>
Received: from mail-ww0-f44.google.com ([74.125.82.44]:32921 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756165Ab1GQSMJ (ORCPT
	<rfc822;linux-perf-users@vger.kernel.org>);
	Sun, 17 Jul 2011 14:12:09 -0400
Content-Disposition: inline
In-Reply-To: <1310754849-12474-1-git-send-email-dsahern@gmail.com>
Sender: linux-perf-users-owner@vger.kernel.org
List-ID: <linux-perf-users.vger.kernel.org>
To: David Ahern <dsahern@gmail.com>, peterz@infradead.org, Arnaldo Carvalho de Melo <acme@ghostprotocols.net>, Ingo Molnar <mingo@elte.hu>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, paulus@samba.org

On Fri, Jul 15, 2011 at 12:34:09PM -0600, David Ahern wrote:
> The perf_event_attr struct has 2 __u32's at the top and need to
> be swapped individually. With this change I was able to analyze
> a perf.data collected in a 32-bit PPC VM on an x86 system. I
> tested both 32-bit and 64-bit binaries for the Intel analysis
> side; both read the PPC perf.data file correctly.
> 
> v1 -> v2:
> - changed the existing perf_event__attr_swap to swap only elements
>   of perf_event_attr and exported it for use in swapping the
>   attributes in the file header
> - updated swap_ops used for processing events
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>

Thanks!

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>