From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
mingo@elte.hu, peterz@infradead.org, fweisbec@gmail.com,
paulus@samba.org, tglx@linutronix.de, anton@samba.org
Subject: Re: [PATCH] perf tool: fix endianness handling of u32 data in samples
Date: Thu, 1 Sep 2011 13:19:00 -0300 [thread overview]
Message-ID: <20110901161900.GB15984@ghostprotocols.net> (raw)
In-Reply-To: <1314654924-13071-1-git-send-email-dsahern@gmail.com>
Em Mon, Aug 29, 2011 at 03:55:24PM -0600, David Ahern escreveu:
> Currently, analyzing PPC data files on x86 the cpu field is always 0 and
> the tid and pid are backwards. For example, analyzing a PPC file on PPC
> the pid/tid fields show:
> rsyslogd 1210/1212
>
> and analyzing the same PPC file using an x86 perf binary shows:
> rsyslogd 1212/1210
>
> The problem is that the swap_op method for samples is
> perf_event__all64_swap which assumes all elements in the sample_data
> struct are u64s. cpu, tid and pid are u32s and need to be handled
> individually. Given that the swap is done before the sample is parsed,
> the simplest solution is to undo the 64-bit swap of those elements when
> the sample is parsed and do the proper swap.
>
> The RAW data field is generic and perf cannot have programmatic knowledge
> of how to treat that data. Instead a warning is given to the user.
>
> Thanks to Anton Blanchard for providing a data file for a mult-CPU
> PPC system so I could verify the fix for the CPU fields.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
cc1: warnings being treated as errors
util/evsel.c: In function ‘perf_event__parse_sample’:
util/evsel.c:379: error: dereferencing pointer ‘p’ does break strict-aliasing rules
util/evsel.c:375: error: dereferencing pointer ‘p’ does break strict-aliasing rules
util/evsel.c:375: error: dereferencing pointer ‘p’ does break strict-aliasing rules
util/evsel.c:371: note: initialized from here
util/evsel.c:376: error: dereferencing pointer ‘({anonymous})’ does break strict-aliasing rules
util/evsel.c:376: error: dereferencing pointer ‘({anonymous})’ does break strict-aliasing rules
util/evsel.c:376: note: initialized from here
util/evsel.c:380: error: dereferencing pointer ‘({anonymous})’ does break strict-aliasing rules
util/evsel.c:380: note: initialized from here
util/evsel.c:414: error: dereferencing pointer ‘p’ does break strict-aliasing rules
util/evsel.c:412: error: dereferencing pointer ‘p’ does break strict-aliasing rules
util/evsel.c:408: note: initialized from here
util/evsel.c:462: error: dereferencing pointer ‘p’ does break strict-aliasing rules
util/evsel.c:450: error: dereferencing pointer ‘p’ does break strict-aliasing rules
util/evsel.c:450: error: dereferencing pointer ‘p’ does break strict-aliasing rules
util/evsel.c:444: note: initialized from here
util/evsel.c:451: error: dereferencing pointer ‘({anonymous})’ does break strict-aliasing rules
util/evsel.c:451: error: dereferencing pointer ‘({anonymous})’ does break strict-aliasing rules
util/evsel.c:451: note: initialized from here
CC /home/acme/git/build/perf//util/symbol.o
make: *** [/home/acme/git/build/perf//util/evsel.o] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/home/acme/git/linux/tools/perf'
[acme@emilia linux]$
[acme@emilia linux]$ uname -a
Linux emilia.ghostprotocols.net 3.0.3-rt12.14.el6rt.x86_64 #1 SMP PREEMPT RT Wed Aug 31 12:38:53 BRT 2011 x86_64 x86_64 x86_64 GNU/Linux
[acme@emilia linux]$ cat /etc/redhat-release
Red Hat Enterprise Linux release 6.0 Beta (Santiago)
[acme@emilia linux]$
- Arnaldo
next prev parent reply other threads:[~2011-09-01 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 21:55 [PATCH] perf tool: fix endianness handling of u32 data in samples David Ahern
2011-09-01 16:19 ` Arnaldo Carvalho de Melo [this message]
2011-09-01 16:41 ` David Ahern
2011-09-01 16:54 ` David Ahern
-- strict thread matches above, loose matches on Subject: below --
2011-09-02 19:41 David Ahern
2011-09-02 20:02 ` Arnaldo Carvalho de Melo
2011-09-02 20:06 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901161900.GB15984@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=anton@samba.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).