From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: perf: prctl(PR_TASK_PERF_EVENTS_DISABLE) has no effect Date: Mon, 30 Jan 2012 12:31:15 +0100 Message-ID: <20120130113115.GA6565@elte.hu> References: <4F22D8D9.3010108@rgmadvisors.com> <20120128120151.GA10390@elte.hu> <4F248938.5030507@rgmadvisors.com> <20120129163235.GB23408@elte.hu> <1327917156.2446.191.camel@twins> <20120130101121.GB8924@elte.hu> <1327921293.2446.202.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1327921293.2446.202.camel@twins> Sender: linux-kernel-owner@vger.kernel.org To: Peter Zijlstra Cc: =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Andrew Steets , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Arnaldo Carvalho de Melo List-Id: linux-perf-users.vger.kernel.org * Peter Zijlstra wrote: > On Mon, 2012-01-30 at 11:11 +0100, Ingo Molnar wrote: > > So, what workflow are you suggesting to Andrew? > > Librarize perf record, then in your code do something like: > > #include "perf_record.h" Maybe. (and then it shouldnt be limited to perf_record.h but should be events.h plus libevents.so or such) > > handle = perf_record_init(); /* creates perf events and creates > a record thread that writes samples > to perf.data, consumes env(PERF_*) > for configuration, registers with > at_exit() for cleanup */ > if (!handle) > /* burn */ > > /* do you other code */ > > perf_record_start(handle); > > /* do the bit you want profiled */ > > perf_record_stop(handle); > > Then build with -lperfrecord or so. Not too hard, right? Isnt a simple prctl() so much easier and faster? What's your concern with the prctl()? This would arguably be the right kind of usage for prctl(): it's an established API/ABI for process/task-wide settings. Thanks, Ingo