From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 2/2] perf: Add a new sort order: SORT_INCLUSIVE Date: Thu, 8 Mar 2012 08:22:58 +0100 Message-ID: <20120308072258.GB20784@elte.hu> References: <1331160079-13821-1-git-send-email-asharma@fb.com> <1331160079-13821-3-git-send-email-asharma@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:55619 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487Ab2CHHXN (ORCPT ); Thu, 8 Mar 2012 02:23:13 -0500 Content-Disposition: inline In-Reply-To: <1331160079-13821-3-git-send-email-asharma@fb.com> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Arun Sharma Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Frederic Weisbecker , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Stephane Eranian , Namhyung Kim , Tom Zanussi , linux-perf-users@vger.kernel.org * Arun Sharma wrote: > @@ -71,8 +71,12 @@ static int perf_evsel__add_hist_entry(struct perf_evsel *evsel, > } > > cursor = &evsel->hists.callchain_cursor; > - he = __hists__add_entry_single(&evsel->hists, al, parent, > - cursor, sample->period); > + if (sort__first_dimension == SORT_INCLUSIVE) > + he = __hists__add_entry_inclusive(&evsel->hists, al, parent, > + cursor, sample->period); > + else > + he = __hists__add_entry_single(&evsel->hists, al, parent, > + cursor, sample->period); If sort__first_dimension is available to hist.c then I think there should still be a simple __hists__add_entry() function in hist.c, which perf_evsel__add_hist_entry() calls - which then calls the static inline __hists__add_entry_inclusive() and __hists__add_entry_single() functions within hist.c. I.e. this refactoring and splitup of the function into two parts is not a detail that should matter to builtin-report.c's perf_evsel__add_hist_entry(). Thanks, Ingo