From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Weisbecker Subject: Re: [PATCH 2/2] perf: Add a new sort order: SORT_INCLUSIVE Date: Thu, 8 Mar 2012 16:39:36 +0100 Message-ID: <20120308153933.GD7976@somewhere.redhat.com> References: <1331160079-13821-1-git-send-email-asharma@fb.com> <1331160079-13821-3-git-send-email-asharma@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:62747 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756597Ab2CHPjm (ORCPT ); Thu, 8 Mar 2012 10:39:42 -0500 Content-Disposition: inline In-Reply-To: <1331160079-13821-3-git-send-email-asharma@fb.com> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Arun Sharma Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Arnaldo Carvalho de Melo , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Stephane Eranian , Namhyung Kim , Tom Zanussi , linux-perf-users@vger.kernel.org On Wed, Mar 07, 2012 at 02:41:19PM -0800, Arun Sharma wrote: > Each entry that used to get added once to the histogram, now is added > chain->nr times, each time with one less entry in the > callchain. > > This will result in a non-leaf function that appears in a lot of > samples to get a histogram entry with lots of hits. > > The user can then drill down into the callchains of functions that > have high inclusive times. I don't yet understand the point of this. Imagine those three hists: a -> b -> c a -> b -> d a-> e -> f The fractal inverted mode (-G) will report this: a-- | ----- b | | | -----c | | | -----d | ----- e | -----f The branch sorting is recursive so outstanding callers appear in the first branches already. So if your goal is to find important callers, I don't see why the existing functionalities aren't enough.