From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Oliver Yang <yangoliver@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] Fix build failures of python/perf.so.
Date: Mon, 22 Jul 2013 12:02:42 -0300 [thread overview]
Message-ID: <20130722150242.GB2157@ghostprotocols.net> (raw)
In-Reply-To: <1374493559-11139-1-git-send-email-yangoliver@gmail.com>
Em Mon, Jul 22, 2013 at 07:45:59PM +0800, Oliver Yang escreveu:
> If gcc and python are not under the standard path, it could cause
> the build failure of perf.so.
How can just adding the prefix to the compiler like that fix something?
Looking at the references to CROSS_COMPILE in tools/perf/Makefile:
-----------------------------------
# Define CROSS_COMPILE as prefix name of compiler if you want
# cross-builds.
<SNIP>
CC = $(CROSS_COMPILE)gcc
AR = $(CROSS_COMPILE)ar
-----------------------------------
Can you provide the make command line you're using that makes it work
for you with this patch?
Thanks,
- Arnaldo
> Signed-off-by: Oliver Yang <yangoliver@gmail.com>
> ---
> tools/perf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 641fccd..9f88f6f 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -151,7 +151,7 @@ PYTHON_EXT_SRCS := $(shell grep -v ^\# util/python-ext-sources)
> PYTHON_EXT_DEPS := util/python-ext-sources util/setup.py $(LIBTRACEEVENT) $(LIBLK)
>
> $(OUTPUT)python/perf.so: $(PYTHON_EXT_SRCS) $(PYTHON_EXT_DEPS)
> - $(QUIET_GEN)CFLAGS='$(CFLAGS)' $(PYTHON_WORD) util/setup.py \
> + $(QUIET_GEN)CFLAGS='$(CROSS_COMPILE)' '$(CFLAGS)' $(PYTHON_WORD) util/setup.py \
> --quiet build_ext; \
> mkdir -p $(OUTPUT)python && \
> cp $(PYTHON_EXTBUILD_LIB)perf.so $(OUTPUT)python/
> --
> 1.8.1.2
next prev parent reply other threads:[~2013-07-22 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 11:45 [PATCH] Fix build failures of python/perf.so Oliver Yang
2013-07-22 15:02 ` Arnaldo Carvalho de Melo [this message]
2013-07-22 18:40 ` Oliver Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722150242.GB2157@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=yangoliver@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).