From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: taeung <treeze.taeung@gmail.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
acme@kernel.org
Subject: Re: [PATCH] modified error code when perf_session__new() fail
Date: Mon, 22 Sep 2014 15:46:16 +0200 [thread overview]
Message-ID: <20140922134616.GC18187@krava.brq.redhat.com> (raw)
In-Reply-To: <1411227895.1690.23.camel@leonhard>
On Sun, Sep 21, 2014 at 12:44:55AM +0900, Namhyung Kim wrote:
> Hi Taeung,
>
> Please CC perf maintainers when you send a perf patch. I'm adding
> Arnaldo who maintains tooling part and Jiri who suggested this change.
>
>
> 2014-09-17 (수), 17:31 +0900, taeung:
> > Hi,
> >
> > I modified error code for the requirement as below.
> >
> > Author: taeung <treeze.taeung@gmail.com>
> > Date: Sat Sep 13 16:22:53 2014 +0900
> >
> > modified error code when perf_session__new() fail
> >
> > Because perf_session__new() could fail
> > for more reasons than just ENOMEM,
> > I modified error code(ENOMEM or EINVAL)
> > into -1.
>
> Hmm.. this seems you copied output of "git show" and send it via an
> email client. I recommend you to use "git format-patch" and "git
> send-email" later.
yep, the patch is mangled.. also following doc might be useful:
Documentation/email-clients.txt
>
> In addition, you forgot to add your Signed-off-by.
>
> That being said I'm okay with the patch itself. Jiri, this is what you
> wanted to do, right?
I have some vague memories about this.. any link to refresh my memory? ;-)
but right, the change seems ok
jirka
next prev parent reply other threads:[~2014-09-22 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 8:31 [PATCH] modified error code when perf_session__new() fail taeung
2014-09-20 15:44 ` Namhyung Kim
2014-09-22 13:46 ` Jiri Olsa [this message]
2014-09-22 15:11 ` Namhyung Kim
2014-09-23 6:23 ` taeung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922134616.GC18187@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=treeze.taeung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).