From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [RFC PATCH] perf tui: Annotate entries in callchains Date: Sat, 28 Mar 2015 13:24:12 -0300 Message-ID: <20150328162412.GO21510@kernel.org> References: <20150320203922.GO16485@kernel.org> <20150320210709.GQ16485@kernel.org> <20150323002708.GB2782@sejong> <3FAA059E-DC0F-4290-BDB5-AE2950D1E1CA@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail.kernel.org ([198.145.29.136]:51165 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbbC1QYJ (ORCPT ); Sat, 28 Mar 2015 12:24:09 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Stephane Eranian Cc: Namhyung Kim , Linux Kernel Mailing List , Jiri Olsa , Peter Zijlstra , Frederic Weisbecker , linux-perf-users@vger.kernel.org, David Ahern , Ingo Molnar Em Fri, Mar 27, 2015 at 04:05:03PM -0700, Stephane Eranian escreveu: > On Mon, Mar 23, 2015 at 9:56 AM, Arnaldo Carvalho de Melo wrote: > > Le 23 mars 2015 13:49:24 GMT-03:00, Stephane Eranian a =E9crit : > >>On Sun, Mar 22, 2015 at 5:27 PM, Namhyung Kim > >>> Did you play with acme/perf/core not tip/perf/core? I got same > >>> problem but then I realize it's not the Arnaldo's tree. When I > >>> changed to acme/perf/core the problem disappeared. :) > >>I was only trying it with tip.git. The patch looke simple enough to > >>apply to tip.git but clearly it relies on some other infrastructure > >>changes which I don't know about. In my case =3D, I care about gett= ing > >>this feature in tip.git or older versions of perf. > > It is all in tip.git by now. > >>> But unfortunately I got this segfault instead.. > > Needs a patch that is in perf/urgent > If I pull tip.git now. Does it have what is needed to work? Yes, it should, but you may hit the bug Namhyumg reported, fixed in: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/= tools/perf/util/annotate.c?id=3D3995614d9b0320e10ce202836c8477e1bcf1a2d= 4 perf annotate: Fix fallback to unparsed disassembler line ---- Humm, by tip.git you mean tip.git/master? /me checks... [acme@ssdandy linux]$ git log --oneline tip/master tools/perf/util/annotate.c | head -5 571564babaa3 Merge branch 'perf/core' 2c7da8c590ad perf annotate: Allow annotation for decompressed kernel mo= dules <------------------ 3995614d9b03 perf annotate: Fix fallback to unparsed disassembler line 48000a1aed74 perf tools: Remove EOL whitespaces 0fb9f2aab738 perf annotate: Fix memory leaks in LOCK handling [acme@ssdandy linux]$ Yeah, it is there, should have everything you need. - Arnaldo