From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH] perf report: Support caller callchain order when using DWARF unwinder. Date: Tue, 3 Nov 2015 12:11:27 -0300 Message-ID: <20151103151127.GM21609@kernel.org> References: <1443971797-25548-1-git-send-email-milian.wolff@kdab.com> <20151103073325.GA23878@krava.brq.redhat.com> <20151103120631.GI21609@kernel.org> <2431085.Wl2WqsIU7l@milian-kdab2> <20151103142837.GJ21609@kernel.org> <20151103143207.GA6117@krava.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kernel.org ([198.145.29.136]:37335 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbbKCPLc (ORCPT ); Tue, 3 Nov 2015 10:11:32 -0500 Content-Disposition: inline In-Reply-To: <20151103143207.GA6117@krava.brq.redhat.com> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Jiri Olsa Cc: Milian Wolff , linux-perf-users@vger.kernel.org, Jiri Olsa , Namhyung Kim , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker Em Tue, Nov 03, 2015 at 03:32:07PM +0100, Jiri Olsa escreveu: > On Tue, Nov 03, 2015 at 11:28:37AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Nov 03, 2015 at 01:54:58PM +0100, Milian Wolff escreveu: > > > On Tuesday, November 3, 2015 9:06:31 AM CET Arnaldo Carvalho de Melo wrote: > > > > I can take it, as soon as you guys agree its something I should :-) > > > > > > Yes, I think it's good as-is. Should I resubmit Jiris patch? Considering that > > > he rewrote the patch, should he send it and add me as tester? How do you > > > handle such situations in the Kernel land? > > So, I'll fix this all up by adding a Signed-off-by: Jiri and a > > Tested-by: Millian, which I think I can do according to the above > > messages and past experience, but the Correct Way to do this would > > be for Jiri to collect your Tested-by and resubmit in a separate > > message, not as a patch added to the text of a thread. > well, I'd rather take it then and test it.. I sent > it out completely untested.. just to show what I meant > > I'll resend and add some test code Sounds like a plan, thanks in advance, - Arnaldo