What is 'web--browse' on builtin-help.c ?

What is 'web--browse' on builtin-help.c ?

[Taeung Song]

Hi, all

I’m checking perf-help subcommand and config ‘help.format’.
source code for them contain functionality for info and web
but functionality for info and web didn’t work well. ( there isn’t problems about ‘man’ )

So, I’m trying to fix the bugs.
There is a function ‘open_html()’ on builtin-help.c as below.

408 static void open_html(const char *path)
409 {
410         execl_perf_cmd("web--browse", "-c", "help.browser", path, NULL);
411 }

excel_perf_cmd() function lastly call execvp(“perf”, (char **)nargv)
and then error messages like.

perf: 'web--browse' is not a perf-command.

Is this leftover from git source code ?


Thanks,
Taeung

  --
To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: What is 'web--browse' on builtin-help.c ?

[Namhyung Kim]

Hi Taeung,

On Wed, Dec 02, 2015 at 12:46:40PM +0900, Taeung Song wrote:
> Hi, all
> 
> I’m checking perf-help subcommand and config ‘help.format’.
> source code for them contain functionality for info and web
> but functionality for info and web didn’t work well. ( there isn’t problems about ‘man’ )
> 
> So, I’m trying to fix the bugs.
> There is a function ‘open_html()’ on builtin-help.c as below.
> 
> 408 static void open_html(const char *path)
> 409 {
> 410         execl_perf_cmd("web--browse", "-c", "help.browser", path, NULL);
> 411 }
> 
> excel_perf_cmd() function lastly call execvp(“perf”, (char **)nargv)
> and then error messages like.
> 
> perf: 'web--browse' is not a perf-command.
> 
> Is this leftover from git source code ?

I think so, there's git-web--browse script to find and run available
web browser on a system.

Thanks,
Namhyung

Re: What is 'web--browse' on builtin-help.c ?

[Taeung Song]

Hi, Namhyung

> On Dec 2, 2015, at 2:05 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> 
> Hi Taeung,
> 
> On Wed, Dec 02, 2015 at 12:46:40PM +0900, Taeung Song wrote:
>> Hi, all
>> 
>> I’m checking perf-help subcommand and config ‘help.format’.
>> source code for them contain functionality for info and web
>> but functionality for info and web didn’t work well. ( there isn’t problems about ‘man’ )
>> 
>> So, I’m trying to fix the bugs.
>> There is a function ‘open_html()’ on builtin-help.c as below.
>> 
>> 408 static void open_html(const char *path)
>> 409 {
>> 410         execl_perf_cmd("web--browse", "-c", "help.browser", path, NULL);
>> 411 }
>> 
>> excel_perf_cmd() function lastly call execvp(“perf”, (char **)nargv)
>> and then error messages like.
>> 
>> perf: 'web--browse' is not a perf-command.
>> 
>> Is this leftover from git source code ?
> 
> I think so, there's git-web--browse script to find and run available
> web browser on a system.
> 

Hum.. I thought why don’t use ’sensible-browser’ command
to launch default browser.
But considering various linux distribution is needed
because some system mightn’t have sensible-browser command.
(I thought we can use this script.)

Thank you for answer anyway.

Thanks,
Taeung