From: Jiri Olsa <jolsa@redhat.com>
To: Michael Petlan <mpetlan@redhat.com>
Cc: linux-perf-users@vger.kernel.org, acme@kernel.org
Subject: Re: [PATCH 1/9] perf test: Adding an entry for the perftool-testsuite
Date: Tue, 29 Mar 2016 21:39:08 +0200 [thread overview]
Message-ID: <20160329193908.GA19392@krava.redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.20.1603290206080.7107@Rudolf-RHEL-7>
On Tue, Mar 29, 2016 at 02:19:17PM +0200, Michael Petlan wrote:
> On Sun, 27 Mar 2016, Jiri Olsa wrote:
> >On Wed, Mar 16, 2016 at 02:50:59PM +0100, Michael Petlan wrote:
> >
> >SNIP
> >
> >>+ ret = chdir("..");
> >>+ ret = ret;
> >
> >hm? ;-)
>
> That must be there, otherwise the compiler would complain about unused
> variable 'ret'. When removing 'ret' at all, the compiler complains about
> ignoring return value of 'chdir()'.
>
> Well, ok, there could be something like:
>
> if(!ret)
> {
> fprintf("FATAL: Cannot cd to ..\n");
> return 1;
> }
I dont see a point of having the ret variable at all then..
jirka
next prev parent reply other threads:[~2016-03-29 19:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1458134357.git.mpetlan@redhat.com>
2016-03-16 13:50 ` [PATCH 1/9] perf test: Adding an entry for the perftool-testsuite Michael Petlan
2016-03-27 12:23 ` Jiri Olsa
2016-03-29 12:57 ` Michael Petlan
2016-03-27 12:23 ` Jiri Olsa
2016-03-27 12:24 ` Jiri Olsa
2016-03-27 12:24 ` Jiri Olsa
2016-03-29 12:19 ` Michael Petlan
2016-03-27 12:24 ` Jiri Olsa
2016-03-29 12:19 ` Michael Petlan
2016-03-29 19:39 ` Jiri Olsa [this message]
2016-03-27 12:24 ` Jiri Olsa
2016-03-16 13:51 ` [PATCH 2/9] perf test: adding new testsuite: common files Michael Petlan
2016-03-16 13:54 ` [PATCH 3/9] perf test: new testsuite: perf annotate tests Michael Petlan
2016-03-16 13:55 ` [PATCH 4/9] perf test: new testsuite: perf buildid-list tests Michael Petlan
2016-03-16 13:55 ` [PATCH 5/9] perf test: new testsuite: perf list tests Michael Petlan
2016-03-16 13:56 ` [PATCH 6/9] perf test: new testsuite: perf probe tests Michael Petlan
2016-03-16 13:56 ` [PATCH 7/9] perf test: new testsuite: perf report tests Michael Petlan
2016-03-16 13:57 ` [PATCH 8/9] perf test: new testsuite: perf stat tests Michael Petlan
2016-03-16 13:57 ` [PATCH 9/9] perf test: new testsuite: perf trace tests Michael Petlan
2015-12-07 18:52 [PATCH 1/9] perf test: Adding an entry for the perftool-testsuite Michael Petlan
2015-12-15 12:03 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329193908.GA19392@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mpetlan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).