From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Milian Wolff <milian.wolff@kdab.com>
Cc: David Ahern <dsahern@gmail.com>, linux-perf-users@vger.kernel.org
Subject: Re: [DONE] Re: Reordering the thread output in perf trace --summary
Date: Mon, 9 May 2016 13:25:16 -0300 [thread overview]
Message-ID: <20160509162516.GB5101@kernel.org> (raw)
In-Reply-To: <36570524.2BCkYtH2gR@milian-kdab2>
Em Mon, May 09, 2016 at 10:28:01AM +0200, Milian Wolff escreveu:
> On Thursday, May 5, 2016 1:04:02 PM CEST Arnaldo Carvalho de Melo wrote:
> > Em Wed, May 04, 2016 at 06:41:23PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Wed, May 04, 2016 at 11:51:04AM +0200, Milian Wolff escreveu:
> > > > On Wednesday, May 4, 2016 11:02:12 AM CEST Milian Wolff wrote:
> > > > While at it, can we similarly reorder the output of the per-thread
> > > > syscall
> > > > list? At the moment it is e.g.:
> > > Take a look at my perf/core branch, I have it working there.
> > > I'm in the process of experimenting with creating some kinde of template
> > > for resorting rb_trees, that will reduce the boilerplace while keeping
> > > it following the principles described in Documentation/rbtree.txt.
> > Ok, done, got really small and easy to change the keys if we want to,
> > not dynamicly tho as-is now, but should be easy, with offsetof 8-)
> > Anyway, I'm satisfied and pushed to perf/core, now looking at why total
> > thread time is zeroed...
> > Please take a look and check if it works for you,
> Great Arnaldo, thanks a lot! A pleasant surprise to come home from a sunny
> weekend and see this gem waiting for me :)
>
> I played around with it, and it does work as advertised. Great work!
Glad you liked it :-)
I'll probably make it use the sched:sched_stat_runtime data as the sort
key for threads if --stat is used, what do you think?
- Arnaldo
next prev parent reply other threads:[~2016-05-09 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 9:02 Reordering the thread output in perf trace --summary Milian Wolff
2016-05-04 9:51 ` Milian Wolff
2016-05-04 21:41 ` Arnaldo Carvalho de Melo
2016-05-05 16:04 ` [DONE] " Arnaldo Carvalho de Melo
2016-05-09 8:28 ` Milian Wolff
2016-05-09 16:25 ` Arnaldo Carvalho de Melo [this message]
2016-05-09 18:03 ` Milian Wolff
2016-05-09 20:12 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509162516.GB5101@kernel.org \
--to=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).