* [PATCH 1/2] perf annotate: use arch->objdump.comment_char in dec__parse()
@ 2016-11-30 15:23 Kim Phillips
2016-11-30 15:48 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Kim Phillips @ 2016-11-30 15:23 UTC (permalink / raw)
To: Chris Ryder, Pawel Moll, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Alexander Shishkin, linux-perf-users,
Will Deacon, Mark Rutland
Cc: linux-kernel
Presume neglected in commit 786c1b5 "perf annotate: Start supporting
cross arch annotation". This doesn't fix a bug since none of the
affected arches support parsing dec/inc instructions yet.
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 3e34ee0..191599e 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -408,7 +408,7 @@ static int dec__parse(struct arch *arch __maybe_unused, struct ins_operands *ops
if (ops->target.raw == NULL)
return -1;
- comment = strchr(s, '#');
+ comment = strchr(s, arch->objdump.comment_char);
if (comment == NULL)
return 0;
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] perf annotate: use arch->objdump.comment_char in dec__parse()
2016-11-30 15:23 [PATCH 1/2] perf annotate: use arch->objdump.comment_char in dec__parse() Kim Phillips
@ 2016-11-30 15:48 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-11-30 15:48 UTC (permalink / raw)
To: Kim Phillips
Cc: Chris Ryder, Pawel Moll, Peter Zijlstra, Ingo Molnar,
Alexander Shishkin, linux-perf-users, Will Deacon, Mark Rutland,
linux-kernel
Em Wed, Nov 30, 2016 at 09:23:33AM -0600, Kim Phillips escreveu:
> Presume neglected in commit 786c1b5 "perf annotate: Start supporting
> cross arch annotation". This doesn't fix a bug since none of the
> affected arches support parsing dec/inc instructions yet.
Applied, good catch, one tiny nit tho:
[PATCH 1/2] perf annotate: use arch->objdump.comment_char in
Please start the summary with a capital letter, i.e. make the above be:
[PATCH 1/2] perf annotate: Use arch->objdump.comment_char in
That is how I've worked pushing stuff to Ingo for years, so for
consistency, please stick to that in your next patches,
Thanks a lot!
- Arnaldo
> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/util/annotate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 3e34ee0..191599e 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -408,7 +408,7 @@ static int dec__parse(struct arch *arch __maybe_unused, struct ins_operands *ops
> if (ops->target.raw == NULL)
> return -1;
>
> - comment = strchr(s, '#');
> + comment = strchr(s, arch->objdump.comment_char);
> if (comment == NULL)
> return 0;
>
> --
> 2.10.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-30 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-30 15:23 [PATCH 1/2] perf annotate: use arch->objdump.comment_char in dec__parse() Kim Phillips
2016-11-30 15:48 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).