linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: perf group <linux-perf-users@vger.kernel.org>, kernel-team@lge.com
Subject: Re: [Question] about symbol__get_source_line() in util/annotate.c
Date: Thu, 23 Feb 2017 14:26:40 +0900	[thread overview]
Message-ID: <20170223052640.GB30710@sejong> (raw)
In-Reply-To: <20170223051413.GA30710@sejong>

On Thu, Feb 23, 2017 at 02:14:13PM +0900, Namhyung Kim wrote:
> Hi Taeung,
> 
> On Thu, Feb 23, 2017 at 12:31:08PM +0900, Taeung Song wrote:
> > 2) Why use the if statement as below ?
> > 
> >     if (percent_max <= 0.5)
> >             goto next;
> > 
> > I think it is more correct to use 0.0 instead of 0.5
> > 
> > What do you think about that ?
> 
> Well, I think that the summary line doesn't want to show too many
> (small) lines.  Using 0.0 instead seems meaningless though.

Ah, that includes 0 percent..

Anyway I can see print_summary() uses MIN_GREEN for this.  We can use
it here instead of the magic number, or might change it to something
different if needed.

Thanks,
Namhyung

  reply	other threads:[~2017-02-23  5:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23  3:31 [Question] about symbol__get_source_line() in util/annotate.c Taeung Song
2017-02-23  5:14 ` Namhyung Kim
2017-02-23  5:26   ` Namhyung Kim [this message]
2017-02-23  7:02     ` Taeung Song
2017-02-23  6:29   ` Taeung Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223052640.GB30710@sejong \
    --to=namhyung@kernel.org \
    --cc=kernel-team@lge.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=treeze.taeung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).