From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Milian Wolff <milian.wolff@kdab.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: Feedback on patches?
Date: Fri, 24 Mar 2017 12:10:09 -0300 [thread overview]
Message-ID: <20170324151009.GC5148@kernel.org> (raw)
In-Reply-To: <2870404.LJF2UlfSYK@agathebauer>
Em Fri, Mar 24, 2017 at 12:59:03PM +0100, Milian Wolff escreveu:
> Hey Arnaldo, others.
>
> Jin Yao has pushed an extremely valuable change set, whichs brings inlined
> frames into view for perf report. So far, he has not gotten any feedback by
> anyone except me.
I was observing this from a distance, there was lively discussion, I was
waiting for the dust to settle so that I could then look at the
implementation aspects.
> Similarly, I have pushed a changeset that complements his, i.e. the one that
> adds `-g srcline`. That one has not gotten any feedback whatsoever.
I saw that one now while looking for this one, that I saw earlier today
on my smartphone.
> So I'm asking - what is required to get these patches reviewed and included? I
> consider both extremely important for C++ application developers like me, who
> face inlined frames regularly due to template code.
> Please consider reviewing and merging them.
The more reviewers, the better, I'm making sure the pull requests I send
to Ingo are CCed here, so that one can see what is being done that may
be taking precedence to other stuff.
But always do as you did here, if a reasonable time has passed without
things you think are ready being merged, advocate for it, show numbers,
etc.
I'll try to look at it ASAP.
- Arnaldo
prev parent reply other threads:[~2017-03-24 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 11:59 Feedback on patches? Milian Wolff
2017-03-24 15:10 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324151009.GC5148@kernel.org \
--to=acme@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).