From: Namhyung Kim <namhyung@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Milian Wolff <milian.wolff@kdab.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
David Ahern <dsahern@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Yao Jin <yao.jin@linux.intel.com>,
kernel-team@lge.com
Subject: Re: [PATCH v2] perf report: distinguish between inliners in the same function
Date: Mon, 15 May 2017 09:44:30 +0900 [thread overview]
Message-ID: <20170515004430.GA22151@sejong> (raw)
In-Reply-To: <87a86igm5q.fsf@firstfloor.org>
Hi Andi,
On Fri, May 12, 2017 at 07:55:13AM -0700, Andi Kleen wrote:
> Milian Wolff <milian.wolff@kdab.com> writes:
> >
> > I think I'm missing something, but isn't this what this function provides? The
> > function above is now being used by the match_chain_inliner function below.
> >
> > Ah, or do you mean for code such as this:
> >
> > ~~~~~
> > inline_func_1(); inline_func_2();
>
> This could be handled by looking at columns or discriminators too (which
> some compilers generate in dwarf). srcline.c would need to be changed
> to also call bfd_get_nearest_discriminator() and pass that extra
> information everywhere.
You're right. The discriminators should be carried too.
Thanks,
Namhyung
prev parent reply other threads:[~2017-05-15 0:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 21:35 [PATCH v2] perf report: distinguish between inliners in the same function Milian Wolff
2017-05-08 8:45 ` Milian Wolff
2017-05-08 16:17 ` Arnaldo Carvalho de Melo
2017-05-10 5:53 ` Namhyung Kim
2017-05-12 10:37 ` Milian Wolff
2017-05-12 13:01 ` Namhyung Kim
2017-05-14 18:10 ` Milian Wolff
2017-05-15 1:21 ` Namhyung Kim
2017-05-15 10:01 ` Milian Wolff
2017-05-16 0:53 ` Namhyung Kim
2017-05-16 13:18 ` Milian Wolff
2017-05-17 6:13 ` Namhyung Kim
2017-05-18 12:20 ` Milian Wolff
2017-05-12 14:55 ` Andi Kleen
2017-05-15 0:44 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515004430.GA22151@sejong \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).