From: Namhyung Kim <namhyung@kernel.org>
To: Milian Wolff <milian.wolff@kdab.com>
Cc: Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
kernel-team@lge.com
Subject: Re: [PATCH 0/7] generate full callchain cursor entries for inlined frames
Date: Tue, 30 May 2017 10:33:03 +0900 [thread overview]
Message-ID: <20170530013303.GA2965@sejong> (raw)
In-Reply-To: <2384048.5gd4jAH0Hk@agathebauer>
On Mon, May 29, 2017 at 08:36:25PM +0200, Milian Wolff wrote:
> On Mittwoch, 24. Mai 2017 17:02:37 CEST Namhyung Kim wrote:
> > On Wed, May 24, 2017 at 03:42:59PM +0200, Milian Wolff wrote:
> > > If you think the above is not a valid assessment, I'll try to change my
> > > patch series to use the IP + 1 trick you suggest. But I really don't
> > > think it's going to work.
> >
> > So I agree that we should do symbol name comparison, but I still
> > prefer setting fake symbol address to [IP, +1]. That would reduce
> > memory space for annotate as well.
>
> Can you expand on this? I can implement this, but without having a way to test
> I don't know whether I'm doing it right or not ;-)
>
> Note that fake symbols cannot be annotated from `perf report` currently. The
> browser just does nothing - no error, nothing. So I'm really unsure how this
> would influence the "memory space for annotate".
Hmm.. nevermind. I missed that it cannot be annotated. And if it
aggregates symbols by name, start address might not be necessary.
Thanks,
Namhyung
next prev parent reply other threads:[~2017-05-30 1:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 19:34 [PATCH 0/7] generate full callchain cursor entries for inlined frames Milian Wolff
2017-05-18 19:34 ` [PATCH 1/7] perf report: remove code to handle inline frames from browsers Milian Wolff
2017-05-18 19:34 ` [PATCH 2/7] perf util: take elf_name as const string in dso__demangle_sym Milian Wolff
2017-05-18 19:34 ` [PATCH 3/7] perf report: create real callchain entries for inlined frames Milian Wolff
2017-05-22 12:19 ` Namhyung Kim
2017-05-24 11:41 ` Milian Wolff
2017-05-18 19:34 ` [PATCH 4/7] perf report: use srcline from " Milian Wolff
2017-05-18 19:34 ` [PATCH 5/7] perf report: fall-back to function name comparison for -g srcline Milian Wolff
2017-05-18 19:34 ` [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff
2017-05-22 12:48 ` Namhyung Kim
2017-05-24 11:46 ` Milian Wolff
2017-06-03 13:51 ` Milian Wolff
2017-06-06 1:33 ` Namhyung Kim
2017-06-06 7:26 ` Milian Wolff
2017-06-06 19:52 ` Arnaldo Carvalho de Melo
2017-05-18 19:34 ` [PATCH 7/7] perf script: mark inlined frames and do not print DSO for them Milian Wolff
2017-05-22 12:11 ` Namhyung Kim
2017-05-24 11:40 ` Milian Wolff
2017-05-18 20:05 ` [PATCH 0/7] generate full callchain cursor entries for inlined frames Milian Wolff
2017-05-22 9:06 ` Namhyung Kim
2017-05-24 11:46 ` Milian Wolff
2017-05-24 13:42 ` Milian Wolff
2017-05-24 15:02 ` Namhyung Kim
2017-05-29 18:36 ` Milian Wolff
2017-05-30 1:33 ` Namhyung Kim [this message]
2017-05-22 12:09 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530013303.GA2965@sejong \
--to=namhyung@kernel.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=kernel-team@lge.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).