From: Thomas Richter <tmricht@linux.vnet.ibm.com>
To: linux-s390@vger.kernel.org, linux-perf-users@vger.kernel.org,
acme@kernel.org, jolsa@redhat.com
Cc: Thomas Richter <tmricht@linux.vnet.ibm.com>
Subject: [PATCH 0/3] perf fix test case 14
Date: Tue, 6 Jun 2017 16:31:53 +0200 [thread overview]
Message-ID: <20170606143156.10471-1-tmricht@linux.vnet.ibm.com> (raw)
I have taken the following commits from Jiri Olsa's
branch perf/attr_test to work on a fix.
Commit-id
070b9644981e perf tests attr: Do not store failed events
c9666c26ead0 perf tests attr: Make compare_data global
10eb9496d1c3 perf tests attr: Fix compare logic
4ba31b633fab perf tests attr: Add 1s for exclude_kernel ..
ede0b0a2e007 perf tests attr: Fix no-delay test
I have then added 3 new fixes
Thomas Richter (3):
perf: fix incorrect sample_type value for perf stat tests
perf: fix exit code check in test case execution
perf: fix perf test case 14
I can test these changes only on s390.
With these changes some test-stat-xxx tests run fine.
How to handle test cases currently unsupported on a platform?
For example test-stat-default issues a setup for
PERF_TYPE_HARDWARE / PERF_COUNT_HW_STALLED_CYCLES_BACKEND
which is not supported on s390. The perf_event_open()
system call fails and no event-00-07--1 file is created.
The compare of the test result then fails because attr.py
has nothing to check against.
We could test if an event file exists and if not report an
unsupported test. Is this a good idea?
Any other proposals?
Right now I have commented out these subtests in my environment.
--
2.9.3
next reply other threads:[~2017-06-06 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 14:31 Thomas Richter [this message]
2017-06-06 14:31 ` [PATCH 1/3] perf: fix incorrect sample_type value for perf stat tests Thomas Richter
2017-06-06 14:31 ` [PATCH 2/3] perf: fix exit code check in test case execution Thomas Richter
2017-06-06 14:31 ` [PATCH 3/3] perf: fix perf test case 14 Thomas Richter
2017-06-07 11:17 ` [PATCH 0/3] perf fix " Jiri Olsa
2017-06-07 14:36 ` Thomas-Mich Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606143156.10471-1-tmricht@linux.vnet.ibm.com \
--to=tmricht@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).