From: Thomas Richter <tmricht@linux.vnet.ibm.com>
To: acme@kernel.org, jolsa@redhat.com, linux-perf-users@vger.kernel.org
Cc: brueckner@linux.vnet.ibm.com,
Thomas Richter <tmricht@linux.vnet.ibm.com>
Subject: [PATCH 3/9] perf: test 15 fix test-stat-group tests
Date: Wed, 9 Aug 2017 08:40:34 +0200 [thread overview]
Message-ID: <20170809064040.50899-3-tmricht@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170809064040.50899-1-tmricht@linux.vnet.ibm.com>
Both test-stat-group and test-stat-group1 fail.
The reason is an invalid check for the read_format
return code. The submitted value is 15 and this
value should be returned by the perf_event_open() call
(which it is).
The comparison however is done against an invalid
value of 3.
Fix this by setting the expected read_format value.
Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
---
tools/perf/tests/attr/test-stat-group | 2 ++
tools/perf/tests/attr/test-stat-group1 | 2 ++
2 files changed, 4 insertions(+)
diff --git a/tools/perf/tests/attr/test-stat-group b/tools/perf/tests/attr/test-stat-group
index fdc1596..8fb3a50 100644
--- a/tools/perf/tests/attr/test-stat-group
+++ b/tools/perf/tests/attr/test-stat-group
@@ -6,10 +6,12 @@ ret = 1
[event-1:base-stat]
fd=1
group_fd=-1
+read_format=15
[event-2:base-stat]
fd=2
group_fd=1
config=1
disabled=0
+read_format=15
enable_on_exec=0
diff --git a/tools/perf/tests/attr/test-stat-group1 b/tools/perf/tests/attr/test-stat-group1
index 2a1f86e..086aa2f 100644
--- a/tools/perf/tests/attr/test-stat-group1
+++ b/tools/perf/tests/attr/test-stat-group1
@@ -6,6 +6,7 @@ ret = 1
[event-1:base-stat]
fd=1
group_fd=-1
+read_format=15
[event-2:base-stat]
fd=2
@@ -13,3 +14,4 @@ group_fd=1
config=1
disabled=0
enable_on_exec=0
+read_format=15
--
2.9.3
next prev parent reply other threads:[~2017-08-09 6:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 6:40 [PATCH 1/9] perf: test 15 fix python error on empty result Thomas Richter
2017-08-09 6:40 ` [PATCH 2/9] perf test: perf test case 15 result ignored Thomas Richter
2017-08-09 6:40 ` Thomas Richter [this message]
2017-08-09 15:15 ` [PATCH 3/9] perf: test 15 fix test-stat-group tests Jiri Olsa
2017-08-09 6:40 ` [PATCH 4/9] perf: test 15 add s390x support for stat test cases Thomas Richter
2017-08-09 15:22 ` Jiri Olsa
2017-08-10 7:15 ` Thomas Richter
2017-08-09 6:40 ` [PATCH 5/9] perf test 15: disable test-record-group tests on s390x Thomas Richter
2017-08-09 6:40 ` [PATCH 6/9] perf test 15: disable test-record-filter " Thomas Richter
2017-08-09 6:40 ` [PATCH 7/9] perf test 15: disable test-record-graph-dwarf test " Thomas Richter
2017-08-09 6:40 ` [PATCH 8/9] perf: test 15 change period and frequency for s390x Thomas Richter
2017-08-09 6:40 ` [PATCH 9/9] perf: test 15 fix expected task value Thomas Richter
2017-08-09 15:01 ` Jiri Olsa
2017-08-09 10:39 ` [PATCH 1/9] perf: test 15 fix python error on empty result Jiri Olsa
2017-08-09 11:02 ` Thomas-Mich Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809064040.50899-3-tmricht@linux.vnet.ibm.com \
--to=tmricht@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).