linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Richter <tmricht@linux.vnet.ibm.com>
To: linux-perf-users@vger.kernel.org
Subject: perf test BPF subtest bpf-prologue test fails on s390x
Date: Wed,  9 Aug 2017 11:24:19 +0200	[thread overview]
Message-ID: <20170809092419.68601-1-tmricht@linux.vnet.ibm.com> (raw)

I investigate perf test BPF for s390x and have a question regarding
the 38.3 subtest (bpf-prologue test) which fails on s390x.

When I turn on trace_printk in tests/bpf-script-test-prologue.c
I see this output in /sys/kernel/debug/tracing/trace:

[root@s8360047 perf]# cat /sys/kernel/debug/tracing/trace
perf-30229 [000] d..2 170161.535791: : f_mode 2001d00000000 offset:0 orig:0
perf-30229 [000] d..2 170161.535809: : f_mode 6001f00000000 offset:0 orig:0
perf-30229 [000] d..2 170161.535815: : f_mode 6001f00000000 offset:1 orig:0
perf-30229 [000] d..2 170161.535819: : f_mode 2001d00000000 offset:1 orig:0
perf-30229 [000] d..2 170161.535822: : f_mode 2001d00000000 offset:2 orig:1
perf-30229 [000] d..2 170161.535825: : f_mode 6001f00000000 offset:2 orig:1
perf-30229 [000] d..2 170161.535828: : f_mode 6001f00000000 offset:3 orig:1
perf-30229 [000] d..2 170161.535832: : f_mode 2001d00000000 offset:3 orig:1
perf-30229 [000] d..2 170161.535835: : f_mode 2001d00000000 offset:4 orig:0
perf-30229 [000] d..2 170161.535841: : f_mode 6001f00000000 offset:4 orig:0

[...]

There are 3 parameters the eBPF program tests/bpf-script-test-prologue.c
accesses: f_mode (member of struct file at offset 140) offset and orig.
They are parameters of the lseek() system call triggered in this
test case in function llseek_loop().

What is really strange is the value of f_mode. It is an 8 byte
value, whereas in the probe event it is defined as a 4 byte value.
The lower 4 bytes are all zero and do not belong to member f_mode.
The correct value should be 2001d for read-only and 6001f for
read-write open mode.

Here is the output of the 'perf test -vv bpf' trace:
   Try to find probe point from debuginfo.
   Matched function: null_lseek [2d9310d]
   Probe point found: null_lseek+0
   Searching 'file' variable in context.
   Converting variable file into trace event.
   converting f_mode in file
   f_mode type is unsigned int.
   Opening /sys/kernel/debug/tracing//README write=0
   Searching 'offset' variable in context.
   Converting variable offset into trace event.
   offset type is long long int.
   Searching 'orig' variable in context.
   Converting variable orig into trace event.
   orig type is int.
   Found 1 probe_trace_events.
   Opening /sys/kernel/debug/tracing//kprobe_events write=1
   Writing event: p:perf_bpf_probe/func _text+8794224 f_mode=+140(%r2):x32
	offset=%r3:s64 orig=%r4:s32

I have the feeling that this is an endianness issue. In file
test/bpf-script-test-prologue.c there is this condition:

   if (f_mode & FMODE_WRITE)
	return 0;

On little endian platforms the value is swapped and becomes
0x2001d. When checking for bit 2 (FMODE_WRITE) the comparison
succeeds in half of the invocations and fails in the other half.

On big endian platforms the value is 0xxxxx00000000 and the
test for write-opened file always fails and all invocations
return zero.

I use Fedora 25 and 
[root@s8360047 ~]# rpm -qa | egrep 'clang|llvm'
llvm-3.8.1-2.fc25.s390x
clang-3.8.1-1.fc25.s390x
clang-libs-3.8.1-1.fc25.s390x
llvm-libs-3.8.1-2.fc25.s390x

Any ideas on how to debug this further.

Thanks Thomas

             reply	other threads:[~2017-08-09  9:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09  9:24 Thomas Richter [this message]
2017-08-10 18:13 ` perf test BPF subtest bpf-prologue test fails on s390x Arnaldo Carvalho de Melo
2017-08-11  5:19   ` Wangnan (F)
2017-08-11  9:17     ` Thomas-Mich Richter
2017-08-11  9:49       ` Fwd: " Thomas-Mich Richter
2017-08-11  9:57       ` Wangnan (F)
2017-08-11 11:13         ` Thomas-Mich Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809092419.68601-1-tmricht@linux.vnet.ibm.com \
    --to=tmricht@linux.vnet.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).