From: Andi Kleen <andi@firstfloor.org>
To: Milian Wolff <milian.wolff@kdab.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]
Date: Mon, 4 Sep 2017 20:40:58 -0700 [thread overview]
Message-ID: <20170905034058.GV2482@two.firstfloor.org> (raw)
In-Reply-To: <1788258.9pJ1GNok8V@milian-kdab2>
> The cycle value gets associated with a sample via it's period value, which is
> used by `perf report` in the analysis. If I get a single "broken" sample with
I always thought it just used the number of samples?
> a cycle count of, say 1E14 and then a million other samples, each with "sane"
> cycle counts of let's say 1E5, then the one broken sample will hold 50% of the
> total amount of measured cycles. So perf report will show that the function
> where the broken sample points to will have a cost of 50%.
I don't think I've seen such a situation. Did you?
BTW I'm not arguing against fixing it, but typically I just
recommend to avoid frequency mode. The fast sampling at the beginning
has caused a range of low level PMU bugs and it is hard to reason about
because of its complex behavior. Also it has no protection against
synchronizing with repeated patterns in the execution, which
can cause bad shadowing effects. If you use the Intel
event aliases they have all sensible periods set by default.
-Andi
next prev parent reply other threads:[~2017-09-05 3:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 19:07 deducing CPU clock rate over time from cycle samples Milian Wolff
2017-06-18 4:22 ` Andi Kleen
2017-06-18 19:53 ` Milian Wolff
2017-08-28 14:08 ` broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples] Milian Wolff
2017-08-28 14:40 ` Milian Wolff
2017-08-28 17:28 ` Andi Kleen
2017-09-01 10:34 ` Milian Wolff
2017-09-01 16:48 ` Andi Kleen
2017-09-04 14:35 ` Milian Wolff
2017-09-05 3:40 ` Andi Kleen [this message]
2017-09-05 12:26 ` Milian Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905034058.GV2482@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).