From: Jiri Olsa <jolsa@redhat.com>
To: yuzhoujian <ufo19890607@gmail.com>
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
dsahern@gmail.com, namhyung@kernel.org, milian.wolff@kdab.com,
arnaldo.melo@gmail.com, yuzhoujian@didichuxing.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Makes all those related functions receive the FILE pointer
Date: Fri, 22 Sep 2017 11:03:19 +0200 [thread overview]
Message-ID: <20170922090319.GF15856@krava> (raw)
In-Reply-To: <1505714122-39141-3-git-send-email-yuzhoujian@didichuxing.com>
On Mon, Sep 18, 2017 at 01:55:20PM +0800, yuzhoujian wrote:
> Signed-off-by: yuzhoujian <yuzhoujian@didichuxing.com>
> ---
> tools/perf/builtin-script.c | 247 ++++++++++++++++++++++++--------------------
> 1 file changed, 136 insertions(+), 111 deletions(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 91b5225..f709f6f 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -486,8 +486,8 @@ static int perf_session__check_output_opt(struct perf_session *session)
> return 0;
> }
>
> -static void print_sample_iregs(struct perf_sample *sample,
> - struct perf_event_attr *attr)
> +static void fprint_sample_iregs(struct perf_sample *sample,
> + struct perf_event_attr *attr, FILE *fp)
please make sure the perf gets compiled after every change,
I think this will break compile because of unused *fp,
use the __maybe_unused attribute
jirka
next prev parent reply other threads:[~2017-09-22 9:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 5:55 [PATCH 0/4] perf script: Add script per-event-dump support yuzhoujian
2017-09-18 5:55 ` [PATCH 1/4] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script yuzhoujian
2017-09-22 9:02 ` Jiri Olsa
2017-09-22 9:02 ` Jiri Olsa
2017-09-22 9:02 ` Jiri Olsa
2017-09-18 5:55 ` [PATCH 2/4] Makes all those related functions receive the FILE pointer yuzhoujian
2017-09-22 9:03 ` Jiri Olsa
2017-09-22 14:14 ` Arnaldo Carvalho de Melo
2017-09-22 9:03 ` Jiri Olsa [this message]
2017-09-22 14:15 ` Arnaldo Carvalho de Melo
2017-09-18 5:55 ` [PATCH 3/4] Add the fp_selection_helper function to set the file pointer for the related functions yuzhoujian
2017-09-22 9:03 ` Jiri Olsa
2017-09-22 14:18 ` Arnaldo Carvalho de Melo
2017-09-18 5:55 ` [PATCH 4/4] Replace printf with fprintf for all the output functions yuzhoujian
2017-09-22 9:03 ` Jiri Olsa
2017-09-22 14:14 ` Arnaldo Carvalho de Melo
2017-09-22 9:03 ` Jiri Olsa
2017-09-18 7:26 ` [PATCH 0/4] perf script: Add script per-event-dump support Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922090319.GF15856@krava \
--to=jolsa@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ufo19890607@gmail.com \
--cc=yuzhoujian@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).