From: Jiri Olsa <jolsa@redhat.com>
To: yuzhoujian <ufo19890607@gmail.com>
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
dsahern@gmail.com, namhyung@kernel.org, milian.wolff@kdab.com,
arnaldo.melo@gmail.com, yuzhoujian@didichuxing.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Replace printf with fprintf for all the output functions
Date: Fri, 22 Sep 2017 11:03:33 +0200 [thread overview]
Message-ID: <20170922090333.GH15856@krava> (raw)
In-Reply-To: <1505714122-39141-5-git-send-email-yuzhoujian@didichuxing.com>
On Mon, Sep 18, 2017 at 01:55:22PM +0800, yuzhoujian wrote:
SNIP
> data->deepest_cstate, data->last_cstate,
> data->wake_reason);
> fprint_sample_pt_spacing(len, fp);
> @@ -1299,10 +1299,10 @@ static void fprint_sample_synth_cbr(struct perf_sample *sample, FILE *fp)
> return;
>
> freq = (le32_to_cpu(data->freq) + 500) / 1000;
> - len = printf(" cbr: %2u freq: %4u MHz ", data->cbr, freq);
> + len = fprintf(fp, " cbr: %2u freq: %4u MHz ", data->cbr, freq);
> if (data->max_nonturbo) {
> percent = (5 + (1000 * data->cbr) / data->max_nonturbo) / 10;
> - len += printf("(%3u%%) ", percent);
> + len += fprintf(fp, "(%3u%%) ", percent);
> }
> fprint_sample_pt_spacing(len, fp);
> }
> @@ -1377,7 +1377,7 @@ static size_t data_src__fprintf(u64 data_src, FILE *fp)
> if (maxlen < len)
> maxlen = len;
>
> - return printf("%-*s", maxlen, out);
> + return fprintf(fp, "%-*s", maxlen, out);
all these 'fp' adding changes should be in separate patch
jirka
next prev parent reply other threads:[~2017-09-22 9:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 5:55 [PATCH 0/4] perf script: Add script per-event-dump support yuzhoujian
2017-09-18 5:55 ` [PATCH 1/4] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script yuzhoujian
2017-09-22 9:02 ` Jiri Olsa
2017-09-22 9:02 ` Jiri Olsa
2017-09-22 9:02 ` Jiri Olsa
2017-09-18 5:55 ` [PATCH 2/4] Makes all those related functions receive the FILE pointer yuzhoujian
2017-09-22 9:03 ` Jiri Olsa
2017-09-22 14:14 ` Arnaldo Carvalho de Melo
2017-09-22 9:03 ` Jiri Olsa
2017-09-22 14:15 ` Arnaldo Carvalho de Melo
2017-09-18 5:55 ` [PATCH 3/4] Add the fp_selection_helper function to set the file pointer for the related functions yuzhoujian
2017-09-22 9:03 ` Jiri Olsa
2017-09-22 14:18 ` Arnaldo Carvalho de Melo
2017-09-18 5:55 ` [PATCH 4/4] Replace printf with fprintf for all the output functions yuzhoujian
2017-09-22 9:03 ` Jiri Olsa
2017-09-22 14:14 ` Arnaldo Carvalho de Melo
2017-09-22 9:03 ` Jiri Olsa [this message]
2017-09-18 7:26 ` [PATCH 0/4] perf script: Add script per-event-dump support Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922090333.GH15856@krava \
--to=jolsa@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ufo19890607@gmail.com \
--cc=yuzhoujian@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).