From: Namhyung Kim <namhyung@kernel.org>
To: Milian Wolff <milian.wolff@kdab.com>
Cc: acme@kernel.org, jolsa@kernel.org,
Jin Yao <yao.jin@linux.intel.com>,
Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@redhat.com>,
kernel-team@lge.com
Subject: Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry
Date: Tue, 10 Oct 2017 13:49:54 +0900 [thread overview]
Message-ID: <20171010044954.GA1870@sejong> (raw)
In-Reply-To: <20171009203310.17362-17-milian.wolff@kdab.com>
Hi Milian,
On Mon, Oct 09, 2017 at 10:33:10PM +0200, Milian Wolff wrote:
> When inline frame resolution is disabled, a bogus srcline is obtained
> for hist entries:
>
> ~~~~~
> $ perf report -s sym,srcline --no-inline --stdio -g none
> 95.21% 0.00% [.] __libc_start_main __libc_start_main+18446603358170398953
> 95.21% 0.00% [.] _start _start+18446650082411225129
> 46.67% 0.00% [.] main main+18446650082411225208
> 38.75% 0.00% [.] hypot hypot+18446603358164312084
> 23.75% 0.00% [.] main main+18446650082411225151
> 20.83% 20.83% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > random.h:143
> 18.12% 0.00% [.] main main+18446650082411225165
> 13.12% 13.12% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > random.tcc:3330
> 4.17% 4.17% [.] __hypot_finite __hypot_finite+163
> 4.17% 4.17% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > random.tcc:3333
> 4.17% 0.00% [.] __hypot_finite __hypot_finite+18446603358164312227
> 4.17% 0.00% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > std::generate_canonical<double, 53ul, std::line
> 2.92% 0.00% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > std::generate_canonical<double, 53ul, std::line
> 2.50% 2.50% [.] __hypot_finite __hypot_finite+11
> 2.50% 2.50% [.] __hypot_finite __hypot_finite+24
> 2.50% 0.00% [.] __hypot_finite __hypot_finite+18446603358164312075
> 2.50% 0.00% [.] __hypot_finite __hypot_finite+18446603358164312088
> ~~~~~
>
> Note how we get very large offsets to main and cannot see any srcline
> from one of the complex or random headers, even though the instruction
> pointers actually lie in code inlined from there.
>
> This patch fixes the mapping to use map__objdump_2mem instead of
> map__objdump_2mem in hist_entry__get_srcline. This fixes the srcline
> values for me when inline resolution is disabled:
>
> ~~~~~
> $ perf report -s sym,srcline --no-inline --stdio -g none
> 95.21% 0.00% [.] __libc_start_main __libc_start_main+233
> 95.21% 0.00% [.] _start _start+41
> 46.88% 0.00% [.] main complex:589
> 43.96% 0.00% [.] main random.h:185
> 38.75% 0.00% [.] hypot hypot+20
> 20.83% 0.00% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > random.h:143
> 13.12% 0.00% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > random.tcc:3330
> 4.17% 4.17% [.] __hypot_finite __hypot_finite+140715545239715
> 4.17% 4.17% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > std::generate_canonical<double, 53ul, std::line
> 4.17% 0.00% [.] __hypot_finite __hypot_finite+163
> 4.17% 0.00% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > random.tcc:3333
> 2.92% 2.92% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > std::generate_canonical<double, 53ul, std::line
> 2.50% 2.50% [.] __hypot_finite __hypot_finite+140715545239563
> 2.50% 2.50% [.] __hypot_finite __hypot_finite+140715545239576
> 2.50% 2.50% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > std::generate_canonical<double, 53ul, std::line
> 2.50% 2.50% [.] std::generate_canonical<double, 53ul, std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> > std::generate_canonical<double, 53ul, std::line
> 2.50% 0.00% [.] __hypot_finite __hypot_finite+11
> ~~~~~
>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Yao Jin <yao.jin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
>
> Note how most of the large offset values are now gone. Most notably,
> we get proper srcline resolution for the random.h and complex headers.
> ---
> tools/perf/util/sort.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index 006d10a0dc96..6f3d109078a3 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -334,7 +334,7 @@ char *hist_entry__get_srcline(struct hist_entry *he)
> if (!map)
> return SRCLINE_UNKNOWN;
>
> - return get_srcline(map->dso, map__rip_2objdump(map, he->ip),
> + return get_srcline(map->dso, map__objdump_2mem(map, he->ip),
> he->ms.sym, true, true);
I'm not sure this is right. IIRC hist_entry->ip is a relative IP so
it needs to be changed for objdump use. Maybe there's some bug on
translating the address but it seems that the original code is
correct. And this change breaks srcline for my test program (which is
a PIE).
Thanks,
Namhyung
> }
>
> --
> 2.14.2
>
next prev parent reply other threads:[~2017-10-10 4:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 20:32 [PATCH v5 00/16] generate full callchain cursor entries for inlined frames Milian Wolff
2017-10-09 20:32 ` [PATCH v5 01/16] perf report: remove code to handle inline frames from browsers Milian Wolff
2017-10-09 20:32 ` [PATCH v5 02/16] perf util: store srcline in callchain_cursor_node Milian Wolff
2017-10-09 20:32 ` [PATCH v5 03/16] perf util: refactor inline_list to operate on symbols Milian Wolff
2017-10-09 20:32 ` [PATCH v5 04/16] perf util: refactor inline_list to store srcline string directly Milian Wolff
2017-10-09 20:32 ` [PATCH v5 05/16] perf report: create real callchain entries for inlined frames Milian Wolff
2017-10-09 20:33 ` [PATCH v5 06/16] perf report: fall-back to function name comparison for -g srcline Milian Wolff
2017-10-09 20:33 ` [PATCH v5 07/16] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff
2017-10-09 20:33 ` [PATCH v5 08/16] perf script: mark inlined frames and do not print DSO for them Milian Wolff
2017-10-09 20:33 ` [PATCH v5 09/16] perf report: compare symbol name for inlined frames when matching Milian Wolff
2017-10-13 13:28 ` Arnaldo Carvalho de Melo
2017-10-09 20:33 ` [PATCH v5 10/16] perf report: compare symbol name for inlined frames when sorting Milian Wolff
2017-10-09 20:33 ` [PATCH v5 11/16] perf report: properly handle branch count in match_chain Milian Wolff
2017-10-13 13:39 ` Arnaldo Carvalho de Melo
2017-10-13 14:08 ` Arnaldo Carvalho de Melo
2017-10-14 19:30 ` Milian Wolff
2017-10-16 14:17 ` Arnaldo Carvalho de Melo
2017-10-16 4:18 ` ravi
2017-10-16 8:27 ` Milian Wolff
2017-10-16 14:19 ` Arnaldo Carvalho de Melo
2017-10-09 20:33 ` [PATCH v5 12/16] perf report: cache failed lookups of inlined frames Milian Wolff
2017-10-09 20:33 ` [PATCH v5 13/16] perf report: cache srclines for callchain nodes Milian Wolff
2017-10-09 20:33 ` [PATCH v5 14/16] perf report: use srcline from callchain for hist entries Milian Wolff
2017-10-09 20:33 ` [PATCH v5 15/16] perf util: enable handling of inlined frames by default Milian Wolff
2017-10-09 20:33 ` [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry Milian Wolff
2017-10-10 4:49 ` Namhyung Kim [this message]
2017-10-12 18:22 ` Milian Wolff
2017-10-12 18:52 ` Jiri Olsa
2017-10-13 11:03 ` Jiri Olsa
2017-10-13 1:19 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010044954.GA1870@sejong \
--to=namhyung@kernel.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kernel-team@lge.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).