linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Thomas Richter <tmricht@linux.vnet.ibm.com>
Cc: mhiramat@kernel.org, linux-perf-users@vger.kernel.org,
	brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com
Subject: Re: [PATCH] perf buildid-cache: update help text for purge command
Date: Thu, 9 Nov 2017 16:16:22 -0300	[thread overview]
Message-ID: <20171109191622.GS4333@kernel.org> (raw)
In-Reply-To: <20171107144853.12925-1-tmricht@linux.vnet.ibm.com>

Em Tue, Nov 07, 2017 at 03:48:53PM +0100, Thomas Richter escreveu:
> From: tmricht <tmricht@linux.vnet.ibm.com>
> 
> Clarify the perf buildid-cache help text for the purge operation.
> The purge subcommand takes a list of files (binaries) as
> option parameter. Make the wording the same as for the add
> and remove operation.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
> Reviewed-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
>  tools/perf/builtin-buildid-cache.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c
> index 9eba7f1add1f..ee4fdb458e26 100644
> --- a/tools/perf/builtin-buildid-cache.c
> +++ b/tools/perf/builtin-buildid-cache.c
> @@ -307,8 +307,8 @@ int cmd_buildid_cache(int argc, const char **argv)
>  		   "file", "kcore file to add"),
>  	OPT_STRING('r', "remove", &remove_name_list_str, "file list",
>  		    "file(s) to remove"),
> -	OPT_STRING('p', "purge", &purge_name_list_str, "path list",
> -		    "path(s) to remove (remove old caches too)"),
> +	OPT_STRING('p', "purge", &purge_name_list_str, "file list",
> +		    "file(s) to remove (remove old caches too)"),
>  	OPT_STRING('M', "missing", &missing_filename, "file",
>  		   "to find missing build ids in the cache"),
>  	OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
> -- 
> 2.13.4

  reply	other threads:[~2017-11-09 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 14:48 [PATCH] perf buildid-cache: update help text for purge command Thomas Richter
2017-11-09 19:16 ` Arnaldo Carvalho de Melo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-10-27 11:01 Thomas Richter
2017-10-28 16:15 ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171109191622.GS4333@kernel.org \
    --to=acme@kernel.org \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tmricht@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).