linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Thomas-Mich Richter <tmricht@linux.vnet.ibm.com>,
	Michael Petlan <mpetlan@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
	linux-perf-users@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 2/3] fixup! perf: introduce errno_to_name() function
Date: Thu, 7 Dec 2017 09:37:17 +0100	[thread overview]
Message-ID: <20171207083717.GD4889@linux.vnet.ibm.com> (raw)
In-Reply-To: <1512635281-20733-3-git-send-email-brueckner@linux.vnet.ibm.com>

Hi Arnaldo,

just looking through my posting and just need a fixup for one hunk.  Please
let me know whether I shall re-post the series again.  Sorry for this
inconvenience.

On Thu, Dec 07, 2017 at 09:28:00AM +0100, Hendrik Brueckner wrote:
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
[...]
> @@ -1659,6 +1658,18 @@ static int trace__fprintf_callchain(struct trace *trace, struct perf_sample *sam
>  	return sample__fprintf_callchain(sample, 38, print_opts, &callchain_cursor, trace->output);
>  }
> 
> +static const char *errno_to_name(int err)
> +{
> +	switch (err) {
> +#define ERRNO_NAME_MAP(_err, _num) case _num: return #_err;
> +	ALL_ERRNO_NAME_MAPPINGS
> +#undef ONE_ERRNO_NAME


diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index b7aef0f..04af6a1 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1663,7 +1663,7 @@ static const char *errno_to_name(int err)
 	switch (err) {
 #define ERRNO_NAME_MAP(_err, _num) case _num: return #_err;
 	ALL_ERRNO_NAME_MAPPINGS
-#undef ONE_ERRNO_NAME
+#undef ERRNO_NAME_MAP
 	default:
 		return "(unknown)";
 		break;

  reply	other threads:[~2017-12-07  8:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07  8:27 [PATCH 0/3] perf: generate s390 syscall table and remove auditlibs dependency Hendrik Brueckner
2017-12-07  8:27 ` [PATCH 1/3] perf s390: generate system call table from asm/unistd.h Hendrik Brueckner
2017-12-07 15:30   ` Arnaldo Carvalho de Melo
2017-12-07 17:37     ` Arnaldo Carvalho de Melo
2017-12-11  9:06       ` Hendrik Brueckner
2017-12-11 14:19         ` Arnaldo Carvalho de Melo
2017-12-07  8:28 ` [PATCH 2/3] perf: introduce errno_to_name() function Hendrik Brueckner
2017-12-07  8:37   ` Hendrik Brueckner [this message]
2017-12-07 14:48     ` [PATCH 2/3] fixup! " Arnaldo Carvalho de Melo
2017-12-07 15:00       ` [PATCH 2/3 v2] perf trace: Introduce errno_to_name() Hendrik Brueckner
2017-12-07 17:52         ` Arnaldo Carvalho de Melo
2017-12-11 11:32           ` Hendrik Brueckner
2017-12-11 15:00             ` Arnaldo Carvalho de Melo
2017-12-07  8:28 ` [PATCH 3/3] perf trace: no longer require auditlibs if syscall tables are present Hendrik Brueckner
2017-12-07 17:53   ` Arnaldo Carvalho de Melo
2017-12-11  9:35     ` Hendrik Brueckner
2017-12-07 15:29 ` [PATCH 0/3] perf: generate s390 syscall table and remove auditlibs dependency Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171207083717.GD4889@linux.vnet.ibm.com \
    --to=brueckner@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=tmricht@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).