linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Paul Clarke <pc@us.ibm.com>,
	linux-rt-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 22/34] perf probe: Cut off the version suffix from event name
Date: Thu, 14 Dec 2017 14:42:35 -0300	[thread overview]
Message-ID: <20171214174247.16841-23-acme@kernel.org> (raw)
In-Reply-To: <20171214174247.16841-1-acme@kernel.org>

From: Masami Hiramatsu <mhiramat@kernel.org>

Cut off the version suffix (e.g. @GLIBC_2.2.5 etc.) from automatic
generated event name. This fixes wildcard event adding like below case;

  =====
  # perf probe -x /lib64/libc-2.25.so malloc*
  Internal error: "malloc_get_state@GLIBC_2" is wrong event name.
    Error: Failed to add events.
  =====

This failure was caused by a versioned suffix symbol.

With this fix, perf probe automatically cuts the suffix after @ as
below.

  =====
  # ./perf probe -x /lib64/libc-2.25.so malloc*
  Added new events:
    probe_libc:malloc_printerr (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:malloc_consolidate (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:malloc_check (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:malloc_hook_ini (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:malloc    (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:malloc_trim (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:malloc_usable_size (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:malloc_stats (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:malloc_info (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:mallochook (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:malloc_get_state (on malloc* in /usr/lib64/libc-2.25.so)
    probe_libc:malloc_set_state (on malloc* in /usr/lib64/libc-2.25.so)

  You can now use it in all perf tools, such as:

	  perf record -e probe_libc:malloc_set_state -aR sleep 1

  =====

Reported-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Reported-by: bhargavb <bhargavaramudu@gmail.com>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Acked-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Reviewed-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Clarke <pc@us.ibm.com>
Cc: linux-rt-users@vger.kernel.org
Link: http://lkml.kernel.org/r/None
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/probe-event.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 262d5da86623..7e582547ac07 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -2584,8 +2584,8 @@ static int get_new_event_name(char *buf, size_t len, const char *base,
 	if (!nbase)
 		return -ENOMEM;
 
-	/* Cut off the dot suffixes (e.g. .const, .isra)*/
-	p = strchr(nbase, '.');
+	/* Cut off the dot suffixes (e.g. .const, .isra) and version suffixes */
+	p = strpbrk(nbase, ".@");
 	if (p && p != nbase)
 		*p = '\0';
 
-- 
2.13.6

  parent reply	other threads:[~2017-12-14 17:42 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 17:42 [GIT PULL 00/34] perf/core improvements and fixes Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 01/34] perf stat: Define a structure for per-thread shadow stats Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 02/34] perf stat: Extend rbtree to support " Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 03/34] perf stat: Create the runtime_stat init/exit function Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 04/34] perf stat: Update per-thread shadow stats Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 05/34] perf stat: Print " Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 06/34] perf stat: Remove a set of shadow stats static variables Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 07/34] perf stat: Allocate shadow stats buffer for threads Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 08/34] perf stat: Update or print per-thread stats Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 09/34] perf thread_map: Enumerate all threads from /proc Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 10/34] perf stat: Remove --per-thread pid/tid limitation Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 11/34] perf stat: Resort '--per-thread' result Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 12/34] perf utils: Move is_directory() to path.h Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 13/34] perf test: Handle properly readdir DT_UNKNOWN Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 14/34] perf perf: Remove duplicate includes Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 15/34] tools include s390: Grab a copy of arch/s390/include/uapi/asm/unistd.h Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 16/34] perf s390: Generate system call table from asm/unistd.h Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 17/34] perf trace: Use generated syscall table on s390 too Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 18/34] perf annotate: Get the cpuid from evsel->evlist->env in symbol__annotate() Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 19/34] perf annotate: Use perf_env when obtaining the arch name Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 20/34] perf env: Adopt perf_env__arch() from the annotate code Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 21/34] perf probe: Add warning message if there is unexpected event name Arnaldo Carvalho de Melo
2017-12-14 17:42 ` Arnaldo Carvalho de Melo [this message]
2017-12-14 17:42 ` [PATCH 23/34] perf probe: Add __return suffix for return events Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 24/34] perf probe: Find versioned symbols from map Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 25/34] perf string: Add {strdup,strpbrk}_esc() Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 26/34] perf probe: Support escaped character in parser Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 27/34] perf evsel: Fix swap for samples with raw data Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 28/34] perf test shell: Fix check open filename arg using 'perf trace' Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 29/34] tools headers: Synchronize KVM arch ABI headers Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 30/34] tools headers: Synchronize kernel x86 UAPI headers Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 31/34] tools arch s390: Do not include header files from the kernel sources Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 32/34] Revert "perf s390: Always build with -fPIC" Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 33/34] perf s390: Always build with -fPIC Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 34/34] perf evsel: Enable ignore_missing_thread for pid option Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214174247.16841-23-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=pc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).