linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Jin Yao <yao.jin@linux.intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 03/34] perf stat: Create the runtime_stat init/exit function
Date: Thu, 14 Dec 2017 14:42:16 -0300	[thread overview]
Message-ID: <20171214174247.16841-4-acme@kernel.org> (raw)
In-Reply-To: <20171214174247.16841-1-acme@kernel.org>

From: Jin Yao <yao.jin@linux.intel.com>

It mainly initializes and releases the rblist which is defined in struct
runtime_stat.

For the original rblist 'runtime_saved_values', it's still kept there
for keeping the patch bisectable.

The rblist 'runtime_saved_values' will be removed in later patch at
switching time.

Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1512482591-4646-4-git-send-email-yao.jin@linux.intel.com
[ Rename 'stat' variables to 'st' to build on centos:{5,6} and others where it shadows a global declaration ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/stat-shadow.c | 17 +++++++++++++++++
 tools/perf/util/stat.h        |  3 +++
 2 files changed, 20 insertions(+)

diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
index 528be3e8d13b..07cfbf613bdc 100644
--- a/tools/perf/util/stat-shadow.c
+++ b/tools/perf/util/stat-shadow.c
@@ -40,6 +40,7 @@ static struct stats runtime_aperf_stats[NUM_CTX][MAX_NR_CPUS];
 static struct rblist runtime_saved_values;
 static bool have_frontend_stalled;
 
+struct runtime_stat rt_stat;
 struct stats walltime_nsecs_stats;
 
 struct saved_value {
@@ -134,6 +135,21 @@ static struct saved_value *saved_value_lookup(struct perf_evsel *evsel,
 	return NULL;
 }
 
+void runtime_stat__init(struct runtime_stat *st)
+{
+	struct rblist *rblist = &st->value_list;
+
+	rblist__init(rblist);
+	rblist->node_cmp = saved_value_cmp;
+	rblist->node_new = saved_value_new;
+	rblist->node_delete = saved_value_delete;
+}
+
+void runtime_stat__exit(struct runtime_stat *st)
+{
+	rblist__exit(&st->value_list);
+}
+
 void perf_stat__init_shadow_stats(void)
 {
 	have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend");
@@ -141,6 +157,7 @@ void perf_stat__init_shadow_stats(void)
 	runtime_saved_values.node_cmp = saved_value_cmp;
 	runtime_saved_values.node_new = saved_value_new;
 	runtime_saved_values.node_delete = saved_value_delete;
+	runtime_stat__init(&rt_stat);
 }
 
 static int evsel_context(struct perf_evsel *evsel)
diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
index c685c41f1fb9..f20240037377 100644
--- a/tools/perf/util/stat.h
+++ b/tools/perf/util/stat.h
@@ -117,12 +117,15 @@ bool __perf_evsel_stat__is(struct perf_evsel *evsel,
 
 void perf_stat_evsel_id_init(struct perf_evsel *evsel);
 
+extern struct runtime_stat rt_stat;
 extern struct stats walltime_nsecs_stats;
 
 typedef void (*print_metric_t)(void *ctx, const char *color, const char *unit,
 			       const char *fmt, double val);
 typedef void (*new_line_t )(void *ctx);
 
+void runtime_stat__init(struct runtime_stat *st);
+void runtime_stat__exit(struct runtime_stat *st);
 void perf_stat__init_shadow_stats(void);
 void perf_stat__reset_shadow_stats(void);
 void perf_stat__update_shadow_stats(struct perf_evsel *counter, u64 count,
-- 
2.13.6

  parent reply	other threads:[~2017-12-14 17:42 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 17:42 [GIT PULL 00/34] perf/core improvements and fixes Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 01/34] perf stat: Define a structure for per-thread shadow stats Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 02/34] perf stat: Extend rbtree to support " Arnaldo Carvalho de Melo
2017-12-14 17:42 ` Arnaldo Carvalho de Melo [this message]
2017-12-14 17:42 ` [PATCH 04/34] perf stat: Update " Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 05/34] perf stat: Print " Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 06/34] perf stat: Remove a set of shadow stats static variables Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 07/34] perf stat: Allocate shadow stats buffer for threads Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 08/34] perf stat: Update or print per-thread stats Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 09/34] perf thread_map: Enumerate all threads from /proc Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 10/34] perf stat: Remove --per-thread pid/tid limitation Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 11/34] perf stat: Resort '--per-thread' result Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 12/34] perf utils: Move is_directory() to path.h Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 13/34] perf test: Handle properly readdir DT_UNKNOWN Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 14/34] perf perf: Remove duplicate includes Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 15/34] tools include s390: Grab a copy of arch/s390/include/uapi/asm/unistd.h Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 16/34] perf s390: Generate system call table from asm/unistd.h Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 17/34] perf trace: Use generated syscall table on s390 too Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 18/34] perf annotate: Get the cpuid from evsel->evlist->env in symbol__annotate() Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 19/34] perf annotate: Use perf_env when obtaining the arch name Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 20/34] perf env: Adopt perf_env__arch() from the annotate code Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 21/34] perf probe: Add warning message if there is unexpected event name Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 22/34] perf probe: Cut off the version suffix from " Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 23/34] perf probe: Add __return suffix for return events Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 24/34] perf probe: Find versioned symbols from map Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 25/34] perf string: Add {strdup,strpbrk}_esc() Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 26/34] perf probe: Support escaped character in parser Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 27/34] perf evsel: Fix swap for samples with raw data Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 28/34] perf test shell: Fix check open filename arg using 'perf trace' Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 29/34] tools headers: Synchronize KVM arch ABI headers Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 30/34] tools headers: Synchronize kernel x86 UAPI headers Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 31/34] tools arch s390: Do not include header files from the kernel sources Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 32/34] Revert "perf s390: Always build with -fPIC" Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 33/34] perf s390: Always build with -fPIC Arnaldo Carvalho de Melo
2017-12-14 17:42 ` [PATCH 34/34] perf evsel: Enable ignore_missing_thread for pid option Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214174247.16841-4-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).